centreborelli / s2p

Satellite Stereo Pipeline
GNU Affero General Public License v3.0
209 stars 67 forks source link

Update to latest mgm #112

Closed oleg-alexandrov closed 2 years ago

oleg-alexandrov commented 2 years ago

Since mgm is the workhorse of s2p, as far as I know, it may be of interest that mgm can crash on the Mac because of the --fast-math compile switch, which cuts corners when dealing with NaN. I submitted a fix for that, and for another lesser issue (https://github.com/gfacciol/mgm/pull/15#pullrequestreview-900982077).

It may be good if s2p is updated to the latest mgm.

carlodef commented 2 years ago

Indeed you are right, thank you @oleg-alexandrov! This is adressed in 8fbe233.