search

centreformicrosimulation / SimPaths

SimPaths is an open-source microsimulation framework for life course analysis, developed and maintained by CeMPA at the University of Essex
5 stars 10 forks source link

Static `this.startYear = 2016` overriding `startYear` argument #30

Closed andrewbaxter439 closed 8 months ago

andrewbaxter439 commented 8 months ago

Introduced in ecf7432b885912b623a0cc5c552ff75bee2adc52 - presume this is perhaps a step in that validation process but thought worth highlighting in case needs reversed.

https://github.com/centreformicrosimulation/SimPaths/blob/e29c5297ad64e5be5f8de15b24006467b05ff3cc/src/main/java/simpaths/model/SimPathsModel.java#L290-L291

andrewbaxter439 commented 8 months ago

Sorry @justin-ven @pbronka - had meant to highlight this in email in case causes problems?

pbronka commented 8 months ago

I don't think this should have made its way onto GitHub but will wait for @justin-ven to comment.

Good news is that it was merged in recently (https://github.com/centreformicrosimulation/SimPaths/pull/29)

justin-ven commented 8 months ago

Looks wrong to me - apologies if I was responsible for it!

pbronka commented 8 months ago

Fixed (https://github.com/centreformicrosimulation/SimPaths/pull/35) so closing, thanks @andrewbaxter439 for spotting this!