centreformicrosimulation / SimPaths

SimPaths is an open-source microsimulation framework for life course analysis, developed and maintained by CeMPA at the University of Essex
6 stars 16 forks source link

bug fixes #38

Closed justin-ven closed 10 months ago

justin-ven commented 10 months ago

Fix bugs to utlity maximisation routines. Add test routine for utility maximisation grids. Correct issue with training data. Update gitignore to omit excel files at database load.

pbronka commented 10 months ago

@justin-ven

Update gitignore to omit excel files at database load.

This actually seems to break the model, at least as it is downloaded from GitHub. If these files are not present at all, they are not re-created by the simulation. I would suggest we add them back in.

justin-ven commented 10 months ago

Ah - I see that I misunderstood what is needed here. Apologies

pbronka commented 10 months ago

To clarify, I think it's fine if they are in gitignore so that updates to them are not pushed to GitHub, but we should provide some version of them nevertheless. It's the same situation as with the database file.

pbronka commented 10 months ago

Brought these two files back here, keeping them in gitignore