centreon / centreon-archived

Centreon is a network, system and application monitoring tool. Centreon is the only AIOps Platform Providing Holistic Visibility to Complex IT Workflows from Cloud to Edge.
https://www.centreon.com
GNU General Public License v2.0
574 stars 240 forks source link

Issue 11673: unify parseShowParameters between CentreonRtDowntime and CentreonRtAcknowledgement #12049

Closed mayrstefan closed 12 months ago

mayrstefan commented 2 years ago

Description

This PR unifies parseShowParameters between CentreonRtDowntime and CentreonRtAcknowledgement classes für CLAPI to get rid of the following message:

PHP Warning:  Undefined array key 1 in /usr/share/centreon/www/class/centreon-clapi/centreonRtDowntime.class.php on line 174

From CentreonRtAcknowledgement we use the more sophisticated handling to parse parameters into type and ressouce From CentreonRtDowntime we use the style to generate the return value

Partially Fixes #11673

Type of change

Target serie

How this pull request can be tested ?

Use CLAPI to add and remove Host and Service-Downtimes

Checklist

Community contributors & Centreon team

The PR is based on the develop branch because that seems is the current default branch.

sonarqube-decoration[bot] commented 2 years ago

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
100.0% 100.0% Duplication

kduret commented 2 years ago

migrated to https://github.com/centreon/centreon-gha/pull/