change module type to module instead of umd in webpack configuration - Githubissues

centreon / centreon-archived

Centreon is a network, system and application monitoring tool. Centreon is the only AIOps Platform Providing Holistic Visibility to Complex IT Workflows from Cloud to Edge.

https://www.centreon.com

GNU General Public License v2.0

574 stars 240 forks source link

change module type to module instead of umd in webpack configuration #12056

Closed Med1233 closed 1 year ago

Med1233 commented 2 years ago

Description

Change the webpack configuration libraryTarget from umd to module with the aim to reduce the bundle size

Type of change

[ ] Patch fixing an issue (non-breaking change)
[x] New functionality (non-breaking change)
[ ] Breaking change (patch or feature) that might cause side effects breaking part of the Software

Target serie

[ ] 21.04.x
[ ] 21.10.x
[ ] 22.04.x
[ ] 22.10.x (master)

How this pull request can be tested ?

Validate that user can access to pages (should be validated by cypress and ligthouse) Execute minimal TNR on legacy / reactJS pages

Community contributors & Centreon team

[x] I have followed the coding style guidelines provided by Centreon
[ ] I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
[ ] I have commented my code, especially hard-to-understand areas of the PR.
[ ] I have rebased my development branch on the base branch (master, maintenance).

Thebarda commented 2 years ago

Is it possible to provide a bunch of before/after about bundle size and lighthouse performance report?

sonarqube-decoration[bot] commented 2 years ago

SonarQube Quality Gate

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

kduret commented 2 years ago

migrated to https://github.com/centreon/centreon-gha/pull/122