Closed kduret closed 1 month ago
[!IMPORTANT]
Review skipped
Auto reviews are limited to specific labels.
Labels to auto review (1)
* coderabbitPlease check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Description
Migrated from https://github.com/centreon/centreon/pull/4178
This PR remove some C++ stack trace present when pullwss module unload by closing the zmq socket before the global destruction of the module. It also use a new library Mojo::IOLoop::Signal to correctly handle sigterm signal, which was not always handled.
Fixes # (issue)
Type of change
Target serie
How this pull request can be tested ?
See the robot tests, connecting a poller to a central and disconecting them should not add any C++ level error in the poller logs. you should test both when the poller go down first (with a sigterm) and when the central go down first.
Checklist
Community contributors & Centreon team