fix(build) Add missing NTP Perl module

centreon / centreon-nsclient-build

Source use to build the centreon NSClient agent

19 stars 3 forks source link

fix(build) Add missing NTP Perl module #25

Closed UrBnW closed 4 years ago

UrBnW commented 4 years ago

Hi,

Let's add Net:NTP Perl module, which is missing at least for os::windows::local::plugin, time mode. Works perfectly fine with.

Thank you 👍

garnier-quentin commented 4 years ago

@UrBnW for net::ntp, we need to patch it like in that issue: https://rt.cpan.org/Public/Bug/Display.html?id=59607

Could you add the patch in build process ?

UrBnW commented 4 years ago

So, I reproduced the issue. I'm wondering whether or not patching Net::NTP is the good approach. There are certainly other included modules which use alarm and which would suffer from this bug. What about finding a global solution instead, for example making --global-timeout Windows compliant ? Feel free :) Thx 👍

garnier-quentin commented 4 years ago

You cannot make it compliant in centreon-plugins.. So we need to patch Net::NTP. It should be nsclient to timeout. But it seems like a bug in nsclient.