centreon / centreon-plugins

Collection of standard plugins to discover and gather cloud-to-edge metrics and status across your whole IT infrastructure.
https://www.centreon.com
Apache License 2.0
311 stars 274 forks source link

[apps::monitoring::speedtest::plugin] accept gdpr #4947

Open joschi99 opened 8 months ago

joschi99 commented 8 months ago

The speedtest command line programm from ookla need's from time to time to accept the GDPR agreement. Every time when this happens the plugin returns "UNKNOWN", because the speedtest is not working anymore. But it seems there is a simple way to solve the problem, because it shut be enough to launch the speedtest command with the option --accept-gdpr. In this case if necessary the agreement will be accepted automatically and the test never fails for this reason.

Is there a way the inject this option?

lucie-dubrunfaut commented 4 months ago

Hello :)

I'm not sure but I believe this is the same request as this issue https://github.com/centreon/centreon-plugins/issues/4799#issuecomment-2051350726 ? Otherwise I'm afraid I don't understand what you mean by accept-gdpr.

joschi99 commented 4 months ago

The speedtest cli from Ookla needs to accept from time in time the GDPR terms, otherwise will not working. In this case the cli shows the terms and user needs to agree with Y. As this will be executed by the plugin without user input the speedtest will not work anymore, but the cli has the option accept-gdpr where the GDPR terms will automatically accepted.

lucie-dubrunfaut commented 3 months ago

Hello :)

First of all, we agree that the GDPR terms must be accepted again only when they change? (which makes sense since we have to read them) In this case the most cautious thing would probably be to report an error in the plugin that would explicitly tell the user that he must himself read and accept the GDPR (maybe again).

And if this is not possible and an accept-gdpr option can be directly transmitted and managed by the cli, in this case we could consider adding an option in the plugin that allows to add options to the cli (not just accept-gdpr specifically) while leaving the user responsible for what he adds in this plugin option.

joschi99 commented 3 months ago

As we have seen the GDPR terms must be accepted after a certain period, so it will happen every 3-4 weeks. But there is no obbligation to read the GDPR terms and if you launch speedtest --accept-gdpr then the GDPR terms will be accepted automatically. Maybe it should be a good idea to add a option on the plugin.

lucie-dubrunfaut commented 3 months ago

Hello :)

We had discuss around this question and we should implement an option free something like --add-speedtest-option where you can add any string as option for the speedtest cli. We assume the user is responsible of the string he uses in this option, leading on the possibility if you want to add --accept-gdpr inside this new option. It should be something like this (this is only pseudo code not current implementation):

 --plugin=apps::monitoring::speedtest::plugin --mode=internet-bandwidth --add-speedtest-option="--accept-gdpr"