centrica-engineering / nucleus-docs

Documentation for the Nucleus Design System
https://nucleus.design
2 stars 10 forks source link

Content - Types purpose #531

Closed RobTobias123 closed 2 months ago

RobTobias123 commented 6 months ago

Outcome

The purpose described for each type, state and variation of each component example.

Scope

Review/improve:

RobTobias123 commented 6 months ago

As discussed this morning, I've opened this ticket to use as a place to address the Docs feedback received from Scottie on the Docs Feedback form:

Screenshot 2024-03-20 at 10 22 24

Actions to address this will be to add a link higher up the page for visibility/hierarchy that links to the visual lists in the Guidelines Assets page, to be added to the ns-icon and ns-illustration components pages.

RobTobias123 commented 6 months ago

Added prominent reciprocal links for illustrations icons and assets.

PR for review please: https://github.com/centrica-engineering/nucleus-docs/pull/533

RobTobias123 commented 2 months ago

Using branch of epic/examples-purpose as the base for the individual PRs.

andij commented 2 months ago
RobTobias123 commented 2 months ago

Looking at ns-inputter type examples - they are all quite self-explanatory to me. Would it be unnecessary to add descriptions here? I feel most people would understand and be familiar with what their purpose is.

RobTobias123 commented 2 months ago

Updated and resolved comments on #653 and #654

RobTobias123 commented 2 months ago

Updated #657

RobTobias123 commented 2 months ago

Merged the approved #658

RobTobias123 commented 2 months ago

Updated #660

RobTobias123 commented 2 months ago

Merged the approved #661

RobTobias123 commented 2 months ago

Merged the approved #662

RobTobias123 commented 2 months ago

Updated #663

RobTobias123 commented 2 months ago

All approved and merged. Closing as completed.

andij commented 2 months ago

I'm reopening this ticket as the epic PR for this ticket has yet to be reviewed:

RobTobias123 commented 2 months ago

Committed and slightly tweaked some of Mekala's suggestions on the Epic branch. (Added 'articles' like 'the' where necessary). All resolved and awaiting final approval.

RobTobias123 commented 2 months ago

Merged this now it has been approved.

RobTobias123 commented 2 months ago

Closing as completed and epic approved and merged.