centrica-engineering / nucleus-docs

Documentation for the Nucleus Design System
https://nucleus.design
1 stars 10 forks source link

[ns-frame] Component documentation #643

Closed MekalaNagarajan-Centrica closed 2 weeks ago

MekalaNagarajan-Centrica commented 3 weeks ago

Outcome

To add component documentation for ns-frame component.

Scope

Pull request:

MekalaNagarajan-Centrica commented 3 weeks ago
RobTobias123 commented 3 weeks ago

Some of the items were covered in PR #642 so have merged that branch (docs/ns frame content) to docs/ns-frame to simplify and update. Next I'm working on the content guidance section to match the latest example in the image and add labels + key as defined in scope on this ticket.

642's preview for reference: https://5a1c387d.nucleus-docs.pages.dev/components/ns-frame/

RobTobias123 commented 3 weeks ago

I've updated the guidance image and labels to include an open account and search, plus added the copy in the key for those sections. Also, now using a bracket type label on the image to indicate the header section. PR #619 for review please.

RobTobias123 commented 3 weeks ago

'Example' is included in the above but utilises different content. Whereas the guidance image is reflecting what is currently live. Should we update the Example to be the same or perhaps it doesn't matter as the frame is ok?