fix: configurator loading issue

cloudflare-pages[bot] commented 3 weeks ago

Deploying nucleus-docs with Cloudflare Pages

Latest commit:	`c4a6faa`
Status:	✅ Deploy successful!
Preview URL:	https://1c39b018.nucleus-docs.pages.dev
Branch Preview URL:	https://fix-frame-configurator-loadi.nucleus-docs.pages.dev

andij commented 3 weeks ago

I wouldn't expect to change the id="content" on the <main> element to id="frame-content" for all examples.

The ns-frame example has two <main> elements in the iframe.

Would it make sense to remove <main class="ndsn" id="content"> from the iframe template.

from this:

<body>
  <main class="ndsn" id="iframe-content">
    ${wrapper}
  </main>
</body>

to this:

<body class="ndsn">
  ${wrapper}
</body>

I'm aware that the <main> element will not be present on the rest of the component examples, but that may be okay for the Docs.

Then the <main id="content"> that is part of the ns-frame example will not interfere.

And change the offsetHeight to be on the <body> element instead of <main>.

Thoughts?

MekalaNagarajan-Centrica commented 3 weeks ago

If the concern is about wrapping in main, then I would expect to do it more logically based on the component placement tag.