search

centricular / gstwebrtc-demos

Superseded by https://gitlab.freedesktop.org/gstreamer/gstreamer/-/tree/main/subprojects/gst-examples/webrtc - Demo apps for using gstreamer's webrtc implementation
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/tree/main/subprojects/gst-examples/webrtc
BSD 2-Clause "Simplified" License
490 stars 197 forks source link

signalling server doesn't reload cert file when it's updated, requires a manual restart #58

Open thbaja opened 5 years ago

thbaja commented 5 years ago

for https://webrtc.nirbheek.in:8443

tp-m commented 5 years ago

cc @nirbheek

nirbheek commented 5 years ago

Oof. The same old problem where when the certificate gets updated, the signalling server doesn't reload the cert file. I've restarted the server, but this should be fixed. Updating issue name.

nirbheek commented 5 years ago

Well, I tried the suggestion in https://stackoverflow.com/a/43875481 to re-instantiate the asyncio server, but it didn't really work (ssl connections started just failing after the reload). Going to try and investigate that a bit more and if it doesn't work, will just implement a restart + inotify behind an option.

Most production deployments I know of put the signalling server behind an nginx proxy anyway.