centrifugal / centrifuge-dart

Dart (Flutter) client SDK for bidirectional communication with Centrifugo and Centrifuge-based server over WebSocket
https://pub.dartlang.org/packages/centrifuge
MIT License
102 stars 29 forks source link

Use relative imports everywhere #25

Closed synw closed 4 years ago

synw commented 4 years ago

My ide gets confused about the types sometimes when I read this library's code. I think this is because there are some mixed relative and absolute imports for internal files: sometimes it is relative and in some other places library files are imported with package:

I suggest that we move all internal imports to relative to avoid namespace confusions and have a better coding experience

FZambia commented 4 years ago

@mogol hello, German, what do you think?

mogol commented 4 years ago

Hey, I tend to use relative imports in the library, absolute was "auto" generated by ide, so it can be replaced without issues.

synw commented 4 years ago

I'm not familiar with auto generated code, got it. Thanks for the explanation. It feels strange to see for example in client.dart the transport.dart being imported twice: one as absolute and one as relative. But well that's the way it is