Web support

[r-oman-G]

Create IWebSocket interface with similar methods in dart:html and dart:io WebSocket. This is have not a big difference between. Test's work normally. Trade-offs noticed: dart:html WebSocket should not use 'protocols' because in this case server will not response. And dart:html WebSocket should use binaryType = 'arraybuffer';

[FZambia]

@r-oman-G thanks, looks very promising! Could you please add a detailed pr description to describe things you done and maybe any trade-offs you noticed?

[r-oman-G]

@FZambia hi, thanks for fast answer. Update pull request

[FZambia]

Trade-offs noticed: dart:html WebSocket should not use 'protocols' because in this case server will not response.

Did you find the underlying reason of this? Would be nice to use centrifuge-protobuf subprotocol to avoid using ?format=protobuf in URL.

Also, plz run dartfmt -w lib/ test/ as CI currently fails.

[r-oman-G]

Did you find the underlying reason of this? Would be nice to use centrifuge-protobuf subprotocol to avoid using ?format=protobuf in URL.

yes, if we do it when we create webSocket then server will not response. Or response something like this "server can't response, try again". I'm try it many times, but anywey dart:html WebSockets can't read our request, if we use protocol during creation WebSockets

Also, plz run dartfmt -w lib/ test/ as CI currently fails.

Okay, I we'll do it tomorrow

[FZambia]

"server can't response, try again". I'm try it many times, but anywey dart:html WebSockets can't read our request, if we use protocol during creation WebSockets

On the server side you are using Centrifugo v2 right? Subprotocol only handled by Centrifugo v3 - maybe thats the reason.

[r-oman-G]

"server can't response, try again". I'm try it many times, but anywey dart:html WebSockets can't read our request, if we use protocol during creation WebSockets

On the server side you are using Centrifugo v2 right? Subprotocol only handled by Centrifugo v3 - maybe thats the reason.

maybe you right, cause i'm test centrifugo only with one server. By the way we use centrifugo v2

[FZambia]

Also, plz run dartfmt -w lib/ test/ as CI currently fails.

Still actual. @r-oman-G are you still interested in getting this merged?

[r-oman-G]

yts i will. Sorry for that, I have no time. I will try try it in next week

вс, 19 сент. 2021 г. в 11:45, Alexander Emelin @.***>:

Also, plz run dartfmt -w lib/ test/ as CI currently fails.

Still actual. @r-oman-G https://github.com/r-oman-G are you still interested in getting this merged?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/centrifugal/centrifuge-dart/pull/53#issuecomment-922438080, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJI4TE26J6JJRHC6M4JIXZTUCWPIZANCNFSM5DJII4QA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[FZambia]

Thx, no rush - just wanted to understand the status.

[FZambia]

There was a problem in CI which resulted in error, need to merge master – and tests should pass.

[adimshev]

Any updates?

[FZambia]

This is still awesome to have, but needs to be addressed over latest version of SDK. So whether this PR should be updated or a new one created.

[FZambia]

Closing in favour of #73