Reconnect improvements, avoid ClientDisconnectedError in _onPing

centrifugal / centrifuge-dart

Dart (Flutter) client SDK for bidirectional communication with Centrifugo and Centrifuge-based server over WebSocket

https://pub.dartlang.org/packages/centrifuge

MIT License

102 stars 29 forks source link

Reconnect improvements, avoid ClientDisconnectedError in _onPing #79

Closed FZambia closed 1 year ago

FZambia commented 1 year ago

This should generally improve reconnect process by only scheduling reconnect routine in onDone handler of the transport. Thus reducing a chance of leaking connections. Also addresses #76 – no exception should be raised when pong message can't be written to closed transport.

TomBeckett commented 1 year ago

Hey @FZambia 👋

Do we know when this may be merged & released?

Thanks!

FZambia commented 1 year ago

@TomBeckett just released v0.9.4 - I suggest spending a bit more time than usual testing centrifuge-dart behaviour before moving to prod, hopefully it will work fine and exceptions go away.