disconnected stale, reconnect false error on android

puryagh commented 4 years ago

hi dear

i use your java library on android with kotlin implemention but when i try to connect with JWT token, returns disconnected stale, reconnect false error but on iOS(swift) and Web version every thing is ok

this is my code

`
val cfListener = object : EventListener() { override fun onConnect(client: Client?, event: ConnectEvent?) { Log.d("CENTRIFUGE", "connected") }

        override fun onDisconnect(client: Client?, event: DisconnectEvent) {
            Log.d(
                "CENTRIFUGE",
                "disconnected %s, reconnect %s%n".format(event.reason, event.reconnect)
            )
        }

        override fun onError(client: Client?, event: ErrorEvent?) {
            super.onError(client, event)
            Log.d("CENTRIFUGE", event.toString())
        }
    }

    Log.d("CENTRIFUGE", Globals.CENTRIFUGE_TOKEN)

    val cfClient = Client(
        Constants.centrifugeBrokerUrl,
        Options(),
        cfListener
    )

    cfClient.setToken(Globals.CENTRIFUGE_TOKEN)
    cfClient.connect()

    val cfSubListener = object : SubscriptionEventListener() {
        override fun onSubscribeSuccess(sub: Subscription, event: SubscribeSuccessEvent?) {
            Log.d("CENTRIFUGE", "subscribed to " + sub.channel)
        }

        override fun onSubscribeError(sub: Subscription, event: SubscribeErrorEvent) {
            Log.d(
                "CENTRIFUGE",
                "subscribe error " + sub.channel.toString() + " " + event.message
            )
        }

        override fun onPublish(sub: Subscription, event: PublishEvent) {
            val data = String(event.data, UTF_8)
            Log.d("CENTRIFUGE", "message from " + sub.channel.toString() + " " + data)
        }
    }

    try {
        val subscription = cfClient.newSubscription("chat#${Globals.SHOP_ID}", cfSubListener)
        subscription.subscribe()
    }catch (e: DuplicateSubscriptionException){
        Log.d("CENTRIFUGE", e.message)
    }`

FZambia commented 4 years ago

Hello, could you please provide a bit more information: 1) Version of centrifuge-java 2) Version of server 3) Does stale disconnect reproduces reliably? 4) Do you have any proxy between client and server? Or you just run server locally?

puryagh commented 4 years ago

hi 1 - java client library version is 0.0.5 2 - server version is 2.7.2 3 - after 3 days and testing for near 2000 time, my android app couldn't connect to centrifugo server even 1 time, but ios and web version worked fine 4 - i tested it with both instance, behind Nginx and locally instance and just android not worked

puryagh commented 4 years ago

OOOps!!! i find reason of problem my android project is based on KOTLIN when i create a new android JAVA project, library worked fine but i don't know why when use library in kotlin project, it couldn't work

puryagh commented 4 years ago

i trace library code

in Client.java at line 617 progress of code stoped and next block not run

Protocol.ConnectRequest req = Protocol.ConnectRequest.newBuilder() .setToken(this.token) .build();

FZambia commented 4 years ago

Hmm, that's strange. Thanks for finding this. Since I never used Kotlin personally will appreciate any help in investigating why this happens.

FZambia commented 4 years ago

Just tried to create basic Kotlin project and it works for me.

I started with Basic Activity template, selected Kotlin language. Code inside MainActivity:

package com.example.myfirstapp

import android.annotation.SuppressLint
import android.os.Bundle
import android.view.Menu
import android.view.MenuItem
import androidx.appcompat.app.AppCompatActivity
import com.google.android.material.snackbar.Snackbar
import io.github.centrifugal.centrifuge.*
import kotlinx.android.synthetic.main.activity_main.*

class MainActivity : AppCompatActivity() {

    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        setContentView(R.layout.activity_main)
        setSupportActionBar(toolbar)

        val listener: EventListener = object : EventListener() {
            @SuppressLint("SetTextI18n")
            override fun onConnect(client: Client?, event: ConnectEvent) {
                println("connect")
            }

            @SuppressLint("SetTextI18n")
            override fun onDisconnect(client: Client?, event: DisconnectEvent) {
                println("disconnect")
            }
        }

        val client = Client(
                "ws://192.168.1.34:8000/connection/websocket?format=protobuf",
                Options(),
                listener
        )
        client.setToken("eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJzdWIiOiJ0ZXN0c3VpdGVfand0In0.hPmHsVqvtY88PvK4EmJlcdwNuKFuy3BGaF7dMaKdPlw")
        client.connect()

        fab.setOnClickListener { view ->
            Snackbar.make(view, "Replace with your own action", Snackbar.LENGTH_LONG)
                    .setAction("Action", null).show()
        }
    }

    override fun onCreateOptionsMenu(menu: Menu): Boolean {
        // Inflate the menu; this adds items to the action bar if it is present.
        menuInflater.inflate(R.menu.menu_main, menu)
        return true
    }

    override fun onOptionsItemSelected(item: MenuItem): Boolean {
        // Handle action bar item clicks here. The action bar will
        // automatically handle clicks on the Home/Up button, so long
        // as you specify a parent activity in AndroidManifest.xml.
        return when (item.itemId) {
            R.id.action_settings -> true
            else -> super.onOptionsItemSelected(item)
        }
    }
}

Set internet permission inside AndroidManifest.xml:

<uses-permission android:name="android.permission.INTERNET" />

After running application I see successful connect in Centrifugo logs:

2020-11-10 02:12:03 [DBG] client connection established client=5967b2de-a6b4-41c9-aa79-ee085cb77b53 transport=websocket
2020-11-10 02:12:04 [DBG] client authenticated client=5967b2de-a6b4-41c9-aa79-ee085cb77b53 user=testsuite_jwt

puryagh commented 4 years ago

yes, it worked in empty android project but in my case

I have GRPC backend service and in prohect gradle already implemented

com.google.protobuf:protobuf-java

now that add centrifuge-java dependency to gradle, protobuf-java must be excluded on it

implementation('io.github.centrifugal:centrifuge-java:0.0.5') { exclude group: 'com.google.protobuf', module: 'protobuf-java' }

if i exclude protobuf-java centrifuge not work 😩 and if don't exclude it duplicated package error occurred

FZambia commented 4 years ago

Maybe GRPC depends on protobuf-javalite package?

Could you try an opposite and exclude javalite package from GRPC instead? I found similar problem in Centrifugo Telegram chat history:

Solution as text:

Fixed this by adding next lines:
    implementation ("com.google.firebase:firebase-perf:19.0.5", {
        exclude group: 'com.google.protobuf', module: 'protobuf-javalite'
        exclude group: 'com.google.protobuf', module: 'protobuf-lite'
    })

So the same problem happened with Firebase. I suppose this should work for GRPC too.

By the way there is a pr that migrates centrifuge-java to protobuf-javalite – https://github.com/centrifugal/centrifuge-java/pull/8

puryagh commented 4 years ago

hi sorry for too long to response thank you for your help

i try this solution before, but it does not worked

finally i use centrifuge-mobile library , its worked perfect

FZambia commented 4 years ago

Looks like I need to test it out myself at some point in the future then. I believe that finding a root cause of this issue is not too hard having a reproducing example (especially since similar stale case already solved by excluding javalite). Personally, I'd go with a native approach instead of centrifuge-mobile especially since you already using centrifuge-swift.

If you can provide a minimal reproducing example this could help a lot

sqrt1764 commented 3 years ago

Greetings I encountered the same issue as puryagh & solved it. It has nothing to do with protobuf. His code was failing because he is missing dependencies. The solution is for him to either include lines 29 & 30 from here https://github.com/centrifugal/centrifuge-java/blob/master/centrifuge/build.gradle#L30 into his project or for you to change implementation to api for those lines, so they are also included for any user of your library.

I also suggest updating this file https://github.com/centrifugal/centrifuge-java/blob/master/README.md When someone new looks at the file it is not clear AT ALL that sections Generate proto & after are in fact documentation for yourself & not for the user of the library. Protobuf-gen of classes is totally irrelevant to the user of the library & is in fact leading him in the wrong direction in solving this issue. There is no need to regenerate classes with protobuf if the protocol has not changed. Hint: separate instructions for yourself into a different file.

sqrt1764 commented 3 years ago

i trace library code

in Client.java at line 617 progress of code stoped and next block not run

Protocol.ConnectRequest req = Protocol.ConnectRequest.newBuilder() .setToken(this.token) .build();

This is happening because he was getting exceptions like this due to the missing libraries I mentioned in my previous comment. Method threw 'java.lang.NoSuchMethodError' exception. Cannot evaluate io.github.centrifugal.centrifuge.internal.protocol.Protocol$ConnectRequest$Builder.toString()

It might be a good idea to introduce some try-catch wrapping & logging in the Runnable's you are passing to your executor, like here - https://github.com/centrifugal/centrifuge-java/blob/master/centrifuge/src/main/java/io/github/centrifugal/centrifuge/Client.java#L185

Library erroring out & swallowing & disappearing all of the crashes is super aggravating 🤬... Yes I had an enjoyable time getting to these solutions /s