search

centrifugal / centrifuge-swift

Swift client SDK for bidirectional real-time communication with Centrifugo and Centrifuge-based server over WebSocket
MIT License
49 stars 44 forks source link

Implemented Delta Fossil Compression #104

Open Mahdibn opened 2 months ago

FZambia commented 2 months ago

Hello @Mahdibn

Thanks! But we still need the code which implements Fossil algorithm to decode deltas.

Mahdibn commented 2 months ago

Hello @Mahdibn

Thanks! But we still need the code which implements Fossil algorithm to decode deltas.

Hello @FZambia Ahh ok I will add it as well 👍🏻

Mahdibn commented 2 months ago

Hello @FZambia, I've just pushed an update to the PR that includes the implementation of the Fossil decoding algorithm. Please take a look when you have a chance and let me know if you have any further feedback.

FZambia commented 2 months ago

@Mahdibn hello, this is cool! Could you please add test test cases to Fossil algorithm implementation? I think it's very important to have. Probably re-use tests cases from other Fossil algorithm implementations? Ex. https://github.com/dchest/fossil-delta-js/tree/master/test

Mahdibn commented 2 months ago

@Mahdibn hello, this is cool! Could you please add test test cases to Fossil algorithm implementation? I think it's very important to have. Probably re-use tests cases from other Fossil algorithm implementations? Ex. https://github.com/dchest/fossil-delta-js/tree/master/test

Hello @FZambia, yes sure I will add them 👍🏻

FZambia commented 1 month ago

Thanks the updates! I see this error in CI:

/Users/runner/work/centrifuge-swift/centrifuge-swift/Tests/SwiftCentrifugeTests/DeltaFossilTests.swift:32: error: -[SwiftCentrifugeTests.DeltaFossilTests testDeltaCreateAndApply] : failed - Could not find file origin
Test Case '-[SwiftCentrifugeTests.DeltaFossilTests testDeltaCreateAndApply]' failed (0.803 seconds).

Probably related to current working directory used during test run