search

centrifugal / centrifuge-swift

Swift client SDK for bidirectional real-time communication with Centrifugo and Centrifuge-based server over WebSocket
MIT License
47 stars 41 forks source link

migrate to StarScream 4. Use custom queue for the callbacks notifications #19

Closed NailxSharipov closed 2 years ago

NailxSharipov commented 4 years ago

migrate to StarScream 4 use more cleanest api for callback notifications. It makes the code more readable.

FZambia commented 4 years ago

@NailxSharipov hello, thanks! BTW - is StarScream 4.0 officially released? I am a bit confused with its releases page where 4.0 tag is not marked as release and there were no patch/minor fixes since then.

NailxSharipov commented 4 years ago

I've just saw it in their readme file, where they suggest to use 4.0. And they have cocoapods release for it. But I don't have any other information on this case.

FZambia commented 4 years ago

Just found an issue https://github.com/daltoniam/Starscream/issues/724 - looks like we better to wait with migration to StarScream 4.

NailxSharipov commented 4 years ago

no problem

FZambia commented 2 years ago

Closing for now (at this point we embedded Starscream 3 to Centrifuge to avoid dependency conflicts), but the issue which tracks this will still be open and we will look for a way to migrate to some robust and maintained WS solution.