search

centrifugal / centrifuge-swift

Swift client SDK for bidirectional real-time communication with Centrifugo and Centrifuge-based server over WebSocket
MIT License
48 stars 44 forks source link

Feature/subscription weak reference #25

Closed NailxSharipov closed 4 years ago

NailxSharipov commented 4 years ago

also rework logic to call func "waitForSubscribe". It's useless to call it on sync queue case in its body it wrap everything in queue

FZambia commented 4 years ago

@NailxSharipov hello, both open pull requests contain almost the same changes (another one is subset of this one), does it mean that only this one is now relevant?

NailxSharipov commented 4 years ago

This one is depend on the previous

NailxSharipov commented 4 years ago

If apply this the other can be deleted. Our you can apply firstly the first, and after this one

FZambia commented 4 years ago

@NailxSharipov could you please update this pr so it reflects real changes against master and resolve existing conflict?

FZambia commented 4 years ago

Thanks for a beautiful refactoring.

FZambia commented 4 years ago

@NailxSharipov a bit busy these days, will make new release with changes very soon but not before next weekend I think.