search

centrifugal / centrifuge-swift

Swift client SDK for bidirectional real-time communication with Centrifugo and Centrifuge-based server over WebSocket
MIT License
47 stars 41 forks source link

Add message recovery support for swift #32

Closed tdh4vn closed 3 years ago

antonselyanin commented 3 years ago

@FZambia What's up with this PR? Any problems with it? I ran a small test, the recovery seems to be working.

FZambia commented 3 years ago

@antonselyanin hi, while this pr works in general there are still some things to do to finish it and make it work properly in edge cases. We discussed state of this pr with @tdh4vn in Telegram - the idea was to merge analogous pr to Java client first and then make similar changes here. The Java pr merged https://github.com/centrifugal/centrifuge-java/pull/19 - there were several important changes atop of original pr - so some work required to finish this one too. Not sure whether @tdh4vn has a time to do this at the moment, so its a bit frozen. Maybe I'll be able to finish this myself at some point but can't say nothing about concrete deadlines.

FZambia commented 3 years ago

@tdh4vn thanks so much for starting work on recovery here, closing in favor of #39