centrifugal / centrifugo

Scalable real-time messaging server in a language-agnostic way. Self-hosted alternative to Pubnub, Pusher, Ably. Set up once and forever.
https://centrifugal.dev
Apache License 2.0
8.44k stars 598 forks source link

Use grouped dependabot version updates #762

Closed j178 closed 10 months ago

j178 commented 10 months ago

Use grouped dependabot version updates to reduce dependabot PR noise.

See

Here is a grouped PR from my repo as an example: https://github.com/j178/leetgo/pull/269

FZambia commented 10 months ago

Hello, @j178 - interesting, thx! Let's try it.

Could you please add github.com/gorilla/websocket to exclude-patterns? The reason - new maintainers of Gorilla WebSocket released new version 1.5.1 which breaks package behaviour in some ways regarding logging upon internal errors - there are some open bugs. So not upgrading to it looking to the situation and it's better to exclude it from group for now. Also, exclude github.com/centrifugal/centrifuge – since it's always manually updated to the required version.

j178 commented 10 months ago

We can add the two to ignore , like this:

version: 2
updates:
  - package-ecosystem: gomod
    directory: "/"
    schedule:
      interval: monthly
    ignore:
      - dependency-name: github.com/gorilla/websocket      # v1.5.1 breaks
      - dependency-name: github.com/centrifugal/centrifuge # updates manually
    groups:
      go-packages:
        patterns: '*'

If add them to exclude-patterns, dependabot will still create seperate PRs for them. What do you think?

FZambia commented 10 months ago

Yep, think it's even better 👍

FZambia commented 10 months ago

Thanks! Noticed a failed dependabot job during CI checks - that patterns should be array, but for some reason can't find it now (Github only shows two successful CI checks, but the job from dependabot gone 🤔 ). Could you please change it to the format like in your repo: https://github.com/j178/leetgo/blob/master/.github/dependabot.yml#L14C18-L14C18

FZambia commented 10 months ago

Many thanks!