search

centrifugal / rubycent

Ruby gem to communicate with Centrifugo HTTP API
MIT License
20 stars 16 forks source link

Improve delgation from class to default client. Drop support of Ruby 1.9 #10

Closed tuned-up closed 7 years ago

tuned-up commented 7 years ago

It allows to call all public methods from default client using Centrifuge class. Also, I found that there is no timeout= method, so i remove a delegation.

tuned-up commented 7 years ago

Seems like gem is incompatible with ruby < 2 Gem::InstallError: public_suffix requires Ruby version >= 2.0.

FZambia commented 7 years ago

@tuned-up thanks! Asked @arrowcircle to review

arrowcircle commented 7 years ago

I think we can drop support of Ruby 1.9. Its EOL long time ago. @FZambia What do You think?

FZambia commented 7 years ago

@arrowcircle I agree - no need to support EOL software, users that need Ruby 1.9 can continue to use current version

arrowcircle commented 7 years ago

@tuned-up could you please remove 1.9 ruby from CI?

@FZambia After merge we need to release 1.2 version with notice about Ruby 1.9 support drop.

tuned-up commented 7 years ago

@arrowcircle 1.9.3 removed!

arrowcircle commented 7 years ago

@tuned-up Thanks!