search

centrifuge / apps

Monorepo for Centrifuge frontends, including Centrifuge App, onboarding api, and Fabric design system.
GNU Lesser General Public License v3.0
27 stars 16 forks source link

Exclude cash assets from asset counts #2232

Open hieronx opened 1 month ago

hieronx commented 1 month ago

On both the Key metrics of the Pool overview and on the Assets tab, the Total assets & Ongoing assets counts should exclude cash assets.

kattylucy commented 2 weeks ago

Hi @hieronx - do you mind adding a bit of context here? do we count cash assets in the total assets? I see this is not true for all the pools (right ?. How can I set up a test for this? TY

hieronx commented 2 weeks ago
Screenshot 2024-07-01 at 15 35 41

If you look at the Anemoy assets now. It is showing 10 total assets and 6 ongoing assets. This is including the Settlement Account, which is a cash asset. It should exclude this, so the total assets should be 9 and the ongoing assets should be 5.

kattylucy commented 2 weeks ago

Is settlement account the only type of cash asset? @hieronx

hieronx commented 2 weeks ago

You should filter any asset where loan.pricing.valuationMethod === 'cash'

kattylucy commented 2 weeks ago

Ah perfect. Thanks @hieronx