search

centrifuge / apps

Monorepo for Centrifuge frontends, including Centrifuge App, onboarding api, and Fabric design system.
GNU Lesser General Public License v3.0
27 stars 16 forks source link

Fix CFG price history on portfolio tab #2380

Open hieronx opened 2 months ago

hieronx commented 2 months ago

Looks like the hosted uniswap v3 subgraph is removed. There is https://thegraph.com/explorer/subgraphs/5zvR82QoaXYFyDEKLZ9t6v9adgnptxYpKpSbxtgVENFV?view=Query&chain=arbitrum-one but that requires an API key. We need to figure out what is the best new data source.

0x4Graham commented 2 months ago

Image

Just wondering, is it meant to look like this?

sophialittlejohn commented 2 months ago

In this bug ticket only the CFG price graph that you can see if you click to send DEVEL or CFG was fixed.

Image

But I looked into why the graph you screenshotted is not showing. Turns out we manually disabled it about 3 months ago, I don't know why (maybe because it really doesn't look good in our app). After that we had a ticket to save space for all graphs on the page while they load to prevent jumping on the screen.

Image

So to summarize: Problem 1: graph was disabled, should we re-enable it? Problem 2: if the graph is disabled we should NOT save space for the graph (probs best for another bug ticket)

sonam-jo commented 4 weeks ago

@hieronx do you have context on why the graph was disabled? This page will be redesigned as well, so I am fine to keep it disabled and remove the space but defer to you

hieronx commented 4 weeks ago

I can't remember why it was disabled, seems to me we should re-enable it.