centrifuge / apps

Monorepo for Centrifuge frontends, including Centrifuge App, onboarding api, and Fabric design system.
GNU Lesser General Public License v3.0
27 stars 16 forks source link

Assets page: Redesign #2507

Open sonam-jo opened 1 month ago

sonam-jo commented 1 month ago

ISSUER Figma: https://www.figma.com/design/ng7qdNcSCXSDA6ZUdWIs6u/Pool-Overview%2F-Pool-Detail?node-id=4014-9891&node-type=canvas&t=u3aSuQHrPp2lwwer-0

Summary box on the top

Assets table

Onchain reserve

Offchain reserve For any of the offchain reserve accounts,

Asset detail page

Side panels for Issuer CTA

INVESTOR Figma: https://www.figma.com/design/ng7qdNcSCXSDA6ZUdWIs6u/Pool-Overview%2F-Pool-Detail?node-id=2521-1083&node-type=canvas&t=u3aSuQHrPp2lwwer-0

Same as Issuer but without any of the CTAs.

0x4Graham commented 3 weeks ago
image

^^ Table not having the responsive design. So on the screen it overflows and not possible to scroll to see. Only seems to be an issue on the bank account, transfer and broker account.

image

Can we decrease the y axis scale on this? Let's not start at 0, Just to show better value increase

0x4Graham commented 3 weeks ago

Not sure if this is just an issue on the dev env, but getting this when looking at what fees to add.:

image
0x4Graham commented 3 weeks ago
image

The dropdown calendar design is missing the same look and feel to the rest of the page

0x4Graham commented 3 weeks ago

Unable to create an asset after completing the fields?

image
sonam-jo commented 3 weeks ago

Total assets should not be 0. It should be the sum of all the assets in the table underneath. And all the 3 fields in the box (onchain, offchain and total assets) should sum up to the total NAV

Screenshot 2024-10-30 at 11 05 01

sonam-jo commented 3 weeks ago

Fields in the table do not match Figma.

Screenshot 2024-10-30 at 11 07 04 Screenshot 2024-10-30 at 11 07 12

sonam-jo commented 3 weeks ago

Chart is missing from Onchain reserve. View transaction column is cut off

Screenshot 2024-10-30 at 11 11 20 Screenshot 2024-10-30 at 11 11 27

hieronx commented 3 weeks ago

Fields in the table do not match Figma. We have Security type instead of Financing date

@kattylucy FYI Security type here is the list of key attributes from the asset template, see https://github.com/centrifuge/apps/blob/main/centrifuge-app/src/components/LoanList.tsx#L91 for how it is implemented now.

sonam-jo commented 3 weeks ago

With all three offchain accounts

Screenshot 2024-10-30 at 11 13 10 Screenshot 2024-10-30 at 11 14 31

sonam-jo commented 3 weeks ago

Currency denomination is in the title, not next to the number

Screenshot 2024-10-30 at 11 19 18 Screenshot 2024-10-30 at 11 19 24

sonam-jo commented 3 weeks ago

Asset detail page is missing the Pricing box. Also add more space/padding between the Price and Unrealized/Realized P&L in the box relative to Asset value - in line with Figma

Screenshot 2024-10-30 at 11 22 17 Screenshot 2024-10-30 at 11 25 02

kattylucy commented 3 weeks ago

Right now for the transaction table we have different values based on the pool type, either private or public. You are not seeing some of those values (like face value for example) because of the pool type. Are we changing this logic to show what the figma table is showing for all public & private, so, should I remove such logic? (Im not sure what is the difference tbd)

@sonam-jo

sonam-jo commented 3 weeks ago

@kattylucy I don't see any changes required for the Transaction history table on the Asset detail page. Those fields can be the same as they are today. As long as the data is coming through, as we have in the app today. Not sure what logic you are referring to?

kattylucy commented 3 weeks ago

No, you are right. I was looking at the wrong table @sonam-jo

sonam-jo commented 3 weeks ago

Screenshot 2024-10-31 at 16 52 43 Screenshot 2024-10-31 at 16 54 28 Screenshot 2024-10-31 at 16 55 22

BrianCarter-Design commented 3 weeks ago

Hi @kattylucy, Here is a link to the QA I've done: https://www.figma.com/design/ng7qdNcSCXSDA6ZUdWIs6u?node-id=4516-1302#1009907355

Much less feedback than on the previous pages, so I think the styles are mostly correct in production now. Well done.

sonam-jo commented 3 weeks ago

A few new changes since the original design. These are also reflected in Figma now.

For both Investor and Issuer view, can we please:

Screenshot 2024-11-01 at 15 22 07

hieronx commented 2 weeks ago

A few post-launch minor feedback points:

Accrued fees should show as 0 rather than -0 if zero:

Screenshot 2024-11-06 at 20 42 00

Sell button (same for Purchase/Finance/Repay) should be primary:

Screenshot 2024-11-06 at 20 43 40

Unrelated to assets, but I think we need to widen the connect wallet button:

Screenshot 2024-11-06 at 20 44 02

The margin near the heading, as well as the padding within the card, and the margin between the grey and white cards, is off compared to design:

Screenshot 2024-11-06 at 20 45 41

vs

image

sonam-jo commented 1 week ago

Only count the ongoing assets that still have a portfolio weighting, not all assets. it should be 6 ongoing assets

Image

sonam-jo commented 1 week ago

Can we please add the total amount for each of the offchain accounts within the dropdown so the user can see the values without having to click on each? Also the ) after USD is missing

Image