Open sonam-jo opened 1 month ago
^^ Table not having the responsive design. So on the screen it overflows and not possible to scroll to see. Only seems to be an issue on the bank account, transfer and broker account.
Can we decrease the y axis scale on this? Let's not start at 0, Just to show better value increase
Not sure if this is just an issue on the dev env, but getting this when looking at what fees to add.:
The dropdown calendar design is missing the same look and feel to the rest of the page
Unable to create an asset after completing the fields?
Total assets should not be 0. It should be the sum of all the assets in the table underneath. And all the 3 fields in the box (onchain, offchain and total assets) should sum up to the total NAV
Fields in the table do not match Figma.
Security type
instead of Financing date
Quantity
instead of Amount
Chart is missing from Onchain reserve. View transaction column is cut off
Fields in the table do not match Figma. We have Security type instead of Financing date
@kattylucy FYI Security type
here is the list of key attributes from the asset template, see https://github.com/centrifuge/apps/blob/main/centrifuge-app/src/components/LoanList.tsx#L91 for how it is implemented now.
With all three offchain accounts
Currency denomination is in the title, not next to the number
Asset detail page is missing the Pricing
box.
Also add more space/padding between the Price and Unrealized/Realized P&L in the box relative to Asset value - in line with Figma
Right now for the transaction table we have different values based on the pool type, either private or public. You are not seeing some of those values (like face value for example) because of the pool type. Are we changing this logic to show what the figma table is showing for all public & private, so, should I remove such logic? (Im not sure what is the difference tbd)
@sonam-jo
@kattylucy I don't see any changes required for the Transaction history table on the Asset detail page. Those fields can be the same as they are today. As long as the data is coming through, as we have in the app today. Not sure what logic you are referring to?
No, you are right. I was looking at the wrong table @sonam-jo
Hi @kattylucy, Here is a link to the QA I've done: https://www.figma.com/design/ng7qdNcSCXSDA6ZUdWIs6u?node-id=4516-1302#1009907355
Much less feedback than on the previous pages, so I think the styles are mostly correct in production now. Well done.
A few new changes since the original design. These are also reflected in Figma now.
For both Investor and Issuer view, can we please:
Accrued fees
to the box on the top always with a "-" minus sign? We need to make sure that Total NAV = Onchain reserve + Offchain cash + Total assets - Accrued fees (so the numbers need to add up correctly)Pool analysis
on the Overview page
) so its obvious that these fields are clickableX ongoing assets
where we calculate the number of ongoing assets A few post-launch minor feedback points:
Accrued fees should show as 0
rather than -0
if zero:
Sell button (same for Purchase/Finance/Repay) should be primary:
Unrelated to assets, but I think we need to widen the connect wallet button:
The margin near the heading, as well as the padding within the card, and the margin between the grey and white cards, is off compared to design:
vs
Only count the ongoing assets that still have a portfolio weighting, not all assets. it should be 6 ongoing assets
Can we please add the total amount for each of the offchain accounts within the dropdown so the user can see the values without having to click on each? Also the ) after USD is missing
ISSUER Figma: https://www.figma.com/design/ng7qdNcSCXSDA6ZUdWIs6u/Pool-Overview%2F-Pool-Detail?node-id=4014-9891&node-type=canvas&t=u3aSuQHrPp2lwwer-0
Summary box on the top
Total Nav
Onchain reserve
that can be clicked to a new page >Offchain reserve
with a drop down option. The drop down shows the list of all offchain accounts that can be clicked to a new page >Create assets
Assets table
View asset transactions
that will direct toAsset transactions
pre selected on theData
tabDownload
Asset list
on theData
tab. The new field isPortfolio %
which is calculated as Market Value of the asset divided by the sum of market value of all assets. Portfolio % will be 0 for repaid assets.Onchain reserve
Offchain reserve For any of the offchain reserve accounts,
Deposit
,Withdraw
(primary)Charge fees
,Correction
(secondary)Asset detail page
Finance/Purchase
,Repay/Sell
,Correction
(depending on the type of asset)Side panels for Issuer CTA
Stablecoins will be transferred to the designated withdrawal addresses on the specified networks. A delay may occur before the transfer is completed.
INVESTOR Figma: https://www.figma.com/design/ng7qdNcSCXSDA6ZUdWIs6u/Pool-Overview%2F-Pool-Detail?node-id=2521-1083&node-type=canvas&t=u3aSuQHrPp2lwwer-0
Same as Issuer but without any of the CTAs.