Remove extra bounds from `pallet_rewards`

centrifuge / centrifuge-chain

Centrifuge Chain: the layer-1 blockchain for real-world assets, built on Substrate.

https://centrifuge.io

GNU Lesser General Public License v3.0

184 stars 81 forks source link

Remove extra bounds from `pallet_rewards` #1777

Closed lemunozm closed 8 months ago

lemunozm commented 8 months ago

Description

Pallet rewards use extra bounds as https://github.com/centrifuge/centrifuge-chain/blob/main/pallets/rewards/src/lib.rs#L428 which are very annoying to use, forcing the users of pallet_rewards carry those bounds everywhere they need a reward usage (i.e. testing with the generic framework of integration tests).

We should either:

add associated type to the Config trait of pallet_rewards instead.
or force the mechanism trait to contains those bounds by default

lemunozm commented 8 months ago

After some testing, the bounds of pallet-rewards are always satisfied internally and do not force the consumers of it to also put them. I think this issue is anyways interesting for readability, but really low low priority, so I close it.