search

centrifuge / centrifuge-chain

Centrifuge Chain: the layer-1 blockchain for real-world assets, built on Substrate.
https://centrifuge.io
GNU Lesser General Public License v3.0
182 stars 78 forks source link

WIP: Liquidity Pools v2 #1909

Closed lemunozm closed 1 month ago

lemunozm commented 2 months ago

Description

LP-V2 base branch where we've merged the individual PRs. For more information, check the individual PRs merged in this branch

lemunozm commented 2 months ago

Modified this PR to ready to review because we want to be sure this branch has always CI in green

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 69.78131% with 152 lines in your changes missing coverage. Please review.

Project coverage is 47.81%. Comparing base (f647a49) to head (a38c4f9). Report is 1 commits behind head on main.

Files Patch % Lines
pallets/liquidity-pools/src/hooks.rs 0.00% 34 Missing :warning:
pallets/liquidity-pools-gateway/queue/src/lib.rs 53.22% 29 Missing :warning:
pallets/foreign-investments/src/entities.rs 77.87% 25 Missing :warning:
pallets/liquidity-pools/src/message.rs 54.71% 24 Missing :warning:
pallets/foreign-investments/src/swaps.rs 75.40% 15 Missing :warning:
libs/mocks/src/liquidity_pools_gateway_queue.rs 0.00% 4 Missing :warning:
pallets/liquidity-pools-gateway/src/lib.rs 66.66% 4 Missing :warning:
pallets/liquidity-pools/src/lib.rs 82.60% 4 Missing :warning:
pallets/foreign-investments/src/impls.rs 95.38% 3 Missing :warning:
pallets/foreign-investments/src/lib.rs 77.77% 2 Missing :warning:
... and 5 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1909 +/- ## ========================================== - Coverage 47.92% 47.81% -0.12% ========================================== Files 181 184 +3 Lines 13159 13036 -123 ========================================== - Hits 6307 6233 -74 + Misses 6852 6803 -49 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lemunozm commented 2 months ago

@wischli are the current failing tests already fixed in https://github.com/centrifuge/centrifuge-chain/pull/1915 or should I fix them (I think I should fix two and ignore the rest)?

wischli commented 2 months ago

@wischli are the current failing tests already fixed in https://github.com/centrifuge/centrifuge-chain/pull/1915 or should I fix them (I think I should fix two and ignore the rest)?

They are not part of #1915 yet but I can definitely include that! Apologies that I didn't check those.

lemunozm commented 2 months ago

No worries at all! It's more. I think the two tests from cases::liquidity_pools::foreign_investments::mismatching_currencies have been probably broken by me after the foreign changes.

I will try to get this green, and then in your PR, fix whatever remains

lemunozm commented 1 month ago

I think the conflicts are due to https://github.com/centrifuge/centrifuge-chain/pull/1926 will and I'll fix on Monday when I'm back

lemunozm commented 1 month ago

Rebased! CI should pass 🤞🏻

lemunozm commented 1 month ago

BTW @wischli I see 6 tests ignored. Did you say 5 in the sync?

lemunozm commented 1 month ago

Finally, this is green! I think we can just rebase and merge