centrifuge / centrifuge-chain

Centrifuge Chain: the layer-1 blockchain for real-world assets, built on Substrate.
https://centrifuge.io
GNU Lesser General Public License v3.0
183 stars 81 forks source link

LP: Unitary testing for add_currency #1912

Closed lemunozm closed 3 months ago

lemunozm commented 3 months ago

Description

Changes and Descriptions

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 30.76923% with 9 lines in your changes missing coverage. Please review.

Project coverage is 46.33%. Comparing base (551fb4c) to head (07ff058).

Files Patch % Lines
pallets/liquidity-pools/src/lib.rs 36.36% 7 Missing :warning:
libs/types/src/domain_address.rs 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1912 +/- ## ========================================== + Coverage 46.30% 46.33% +0.03% ========================================== Files 179 179 Lines 13081 13074 -7 ========================================== + Hits 6057 6058 +1 + Misses 7024 7016 -8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lemunozm commented 3 months ago

This is ready to be merged if you agree in the above clean up

lemunozm commented 3 months ago

Yeah, lp tests are not modified