search

centrifuge / centrifuge-chain

Centrifuge Chain: the layer-1 blockchain for real-world assets, built on Substrate.
https://centrifuge.io
GNU Lesser General Public License v3.0
184 stars 81 forks source link

Clean: Remove unused gateway origin #1976

Closed lemunozm closed 3 months ago

lemunozm commented 3 months ago

Description

We can simplify the gateway a bit more by removing the now unused origin. But feel free to skip this PR if we reach the audit deadline before

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 48.96%. Comparing base (f1af973) to head (0cae722).

Files Patch % Lines
runtime/altair/src/lib.rs 0.00% 1 Missing :warning:
runtime/centrifuge/src/lib.rs 0.00% 1 Missing :warning:
runtime/development/src/lib.rs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1976 +/- ## ========================================== + Coverage 48.90% 48.96% +0.06% ========================================== Files 184 183 -1 Lines 13205 13202 -3 ========================================== + Hits 6458 6465 +7 + Misses 6747 6737 -10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lemunozm commented 3 months ago

CI fails when calling this Solidity constructor: https://github.com/centrifuge/liquidity-pools/blob/6e8f1a29dff0d7cf5ff74285cfffadae8a8b303f/src/factories/TransferProxyFactory.sol#L62 which makes absolute no sense

lemunozm commented 3 months ago

Oh, man... I can't believe it 🫠. My mind no longer works...