search

centrifuge / centrifuge-chain

Centrifuge Chain: the layer-1 blockchain for real-world assets, built on Substrate.
https://centrifuge.io
GNU Lesser General Public License v3.0
182 stars 78 forks source link

Fix: avoid infinite recursion with Message::max_encoded_len() #1982

Closed lemunozm closed 3 weeks ago

lemunozm commented 3 weeks ago

Description

This issue fixes the max_encoded_len() to avoid infinite computation in Message type.

This PR fixes our benchmarking CI job, which passes even encountering the error

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 49.01%. Comparing base (6d5596f) to head (7a54ad1). Report is 1 commits behind head on main.

Files Patch % Lines
pallets/liquidity-pools/src/message.rs 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1982 +/- ## ========================================== + Coverage 48.94% 49.01% +0.07% ========================================== Files 183 183 Lines 13202 13201 -1 ========================================== + Hits 6462 6471 +9 + Misses 6740 6730 -10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.