Reactor: Decoupling pool-registry from pool-system and pool-fees

[lemunozm]

Description

The intention of this PR is to clean the mess we currently have when testing/benchmarking pool things from pool-registry PoV. Production logic is almost untouched, only for cases that affect the benchmarking

NOTE: Current tests do not cover everything, but they cover what the same they covered before the refactor.

Changes and Descriptions

• Remove all pool-related dependencies from pool-registry (look at the mock.rs file!)
• Added BoundedVec when needed to carry the Max information associated to those vecs
• Remove PoolMetadata trait which is not used.
• Simplify weight computation by removing some unused extra params.
• Based of this comment I removed the capability of update & execute in the same call, which is impossible to be used right now in the runtime, and in case of required, it can be batched. Tell me if you agree or I revert.
  • This helps a lot simplifying the benchmarking infrastructure
• Reorganize benchmarking traits (WIP)
• Other minor simplifications

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 17.24138% with 96 lines in your changes missing coverage. Please review.

Project coverage is 48.15%. Comparing base (927af06) to head (6f94dba).

Files with missing lines	Patch %	Lines
pallets/pool-system/src/impls.rs	10.38%	69 Missing :warning:
libs/mocks/src/pools.rs	50.00%	8 Missing :warning:
pallets/pool-fees/src/lib.rs	0.00%	7 Missing :warning:
pallets/pool-registry/src/benchmarking.rs	0.00%	3 Missing :warning:
libs/traits/src/lib.rs	0.00%	2 Missing :warning:
pallets/pool-registry/src/lib.rs	66.66%	2 Missing :warning:
pallets/pool-system/src/benchmarking.rs	0.00%	2 Missing :warning:
pallets/pool-fees/src/benchmarking.rs	0.00%	1 Missing :warning:
runtime/altair/src/lib.rs	0.00%	1 Missing :warning:
runtime/centrifuge/src/lib.rs	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1983 +/- ## ========================================== - Coverage 48.28% 48.15% -0.13% ========================================== Files 183 183 Lines 13406 13359 -47 ========================================== - Hits 6473 6433 -40 + Misses 6933 6926 -7 ``` | [Flag](https://app.codecov.io/gh/centrifuge/centrifuge-chain/pull/1983/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=centrifuge) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/centrifuge/centrifuge-chain/pull/1983/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=centrifuge) | `48.15% <17.24%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=centrifuge#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.