centrifuge / centrifuge-chain

Centrifuge Chain: the layer-1 blockchain for real-world assets, built on Substrate.
https://centrifuge.io
GNU Lesser General Public License v3.0
184 stars 81 forks source link

Attach pre-built binaries to github releases #550

Open wpank opened 2 years ago

wpank commented 2 years ago

Similar to how Parity does this for Polkadot, would be very useful for node operators to attach pre-built binaries to github releases, as well as include rust versions that are used to compile them. This saves people the trouble of needing to intsall rust, figure out what version the chain you have needs to be built with, etc.

For example for the latest release of the centrifuge chain (Centrifuge v2.0.0-RC6 - 245), compiling gives me the following errors:

   Compiling sp-wasm-interface v2.0.0-rc6 (https://github.com/centrifuge/substrate.git?rev=be8bb186d87b9d2b47a2907c9b51ae1e252362c3#be8bb186)
   Compiling sp-arithmetic v2.0.0-rc6 (https://github.com/centrifuge/substrate.git?rev=be8bb186d87b9d2b47a2907c9b51ae1e252362c3#be8bb186)
   Compiling fork-tree v2.0.0-rc6 (https://github.com/centrifuge/substrate.git?rev=be8bb186d87b9d2b47a2907c9b51ae1e252362c3#be8bb186)
   Compiling finality-grandpa v0.12.3
error[E0282]: type annotations needed
    --> /home/ubuntu/.cargo/git/checkouts/substrate-c08550cb428dbcc9/be8bb18/primitives/arithmetic/src/fixed_point.rs:541:9
     |
541  |                   let accuracy = P::ACCURACY.saturated_into();
     |                       ^^^^^^^^ consider giving `accuracy` a type
...
1595 | / implement_fixed!(
1596 | |     FixedI64,
1597 | |     test_fixed_i64,
1598 | |     i64,
...    |
1601 | |     "_Fixed Point 64 bits signed, range = [-9223372036.854775808, 9223372036.854775807]_",
1602 | | );
     | |__- in this macro invocation
     |
     = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0282]: type annotations needed
    --> /home/ubuntu/.cargo/git/checkouts/substrate-c08550cb428dbcc9/be8bb18/primitives/arithmetic/src/fixed_point.rs:541:9
     |
541  |                   let accuracy = P::ACCURACY.saturated_into();
     |                       ^^^^^^^^ consider giving `accuracy` a type
...
1604 | / implement_fixed!(
1605 | |     FixedI128,
1606 | |     test_fixed_i128,
1607 | |     i128,
...    |
1611 | |         [-170141183460469231731.687303715884105728, 170141183460469231731.687303715884105727]_",
1612 | | );
     | |__- in this macro invocation
     |
     = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0282]: type annotations needed
    --> /home/ubuntu/.cargo/git/checkouts/substrate-c08550cb428dbcc9/be8bb18/primitives/arithmetic/src/fixed_point.rs:541:9
     |
541  |                   let accuracy = P::ACCURACY.saturated_into();
     |                       ^^^^^^^^ consider giving `accuracy` a type
...
1614 | / implement_fixed!(
1615 | |     FixedU128,
1616 | |     test_fixed_u128,
1617 | |     u128,
...    |
1621 | |         [0.000000000000000000, 340282366920938463463.374607431768211455]_",
1622 | | );
     | |__- in this macro invocation
     |
     = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

   Compiling jsonrpc-ws-server v14.2.0
error: aborting due to 3 previous errors

People that run nodes generally don't want to deal with rust errors :grimacing:

mustermeiszer commented 2 years ago

I think this is a good idea. WDYT @mikiquantum?

Note: As we will retire master in order to switch to our parachain branch and with high probability won't release another release for our current stand-alone this will most likely land only for parachain.

mustermeiszer commented 2 years ago

With which rust version are you compiling @wpank? Have not built it in a while but this one should work nightly-2020-08-16.

wpank commented 2 years ago

With which rust version are you compiling @wpank? Have not built it in a while but this one should work nightly-2020-08-16.

Yes, I was eventualy able to compile it with nightly-2020-10-01

mikiquantum commented 2 years ago

@mustermeiszer Yes we already discussed this in our internal meeting, its added to our backlog.

mikiquantum commented 2 years ago

This is an overall improvement haul on our CI release, we will track it there: https://github.com/centrifuge/centrifuge-chain/issues/400