search

ceoloide / ergogen-footprints

Ergogen v4 footprints
MIT License
47 stars 14 forks source link

Jumpers dont rotate with the controller #1

Closed Dollehz closed 9 months ago

Dollehz commented 9 months ago

When the niceNano controller is at an angle the jumper pads stay oriented horizontal.

image

ceoloide commented 9 months ago

Thanks for reporting! I believe the rotation parameter.is missing, will modify ASAP.

I am creating a test / demo board for the footprints to uncover problems like these at https://github.com/ceoloide/ergogen-footprints-demo and will soon link it to this repo. If you have any advice on what to test for, let me know. I plan to fabricate the board to validate footprints in real life.

ceoloide commented 9 months ago

I've committed the changes necessary to enable dynamic rotation for all elements of the footprint, since silkscreen and labels were also not rotating.

To update the submisule and get the latest code, I use this command:

git submodule update --init --remote

Will track this for other footprints in an another issue. Thank you so much for reporting it!

Here's a preview of the change: Screenshot_20240220-204211