search

ceph / calamari-clients

Ceph Manager API Client Code
Other
101 stars 59 forks source link

DNM: calamari chinese version #55

Closed ChristinaMeno closed 9 years ago

ChristinaMeno commented 10 years ago 
Provide an original chinese version of calamari-clients

Signed-off-by: xianxia xiao xianxiaxiao@ubuntukylin.com

yanfali commented 10 years ago

I totally the appreciate the hard work that went into this, I'm not sure how you should merge this. Won't this simply overwrite the en version on merge?

Ideally the l20n folder needs a chinese one added and all the ejs templates need to be the English text extracted.

The angular side was never localized properly due to time constraints and the backbone code needs more strings to be extracted into the l20n file and substituted at run time.

dmick commented 10 years ago

Yeah, it needs work. On Oct 21, 2014 7:15 AM, "Yan-Fa Li" notifications@github.com wrote:

I totally the appreciate the hard work that went into this, I'm not sure how you should merge this. Won't this simply overwrite the en version on merge?

Ideally the l20n folder needs a chinese one added and all the ejs templates need to be the English text extracted.

The angular side was never localized properly due to time constraints and the backbone code needs more strings to be extracted into the l20n file and substituted at run time.

— Reply to this email directly or view it on GitHub https://github.com/ceph/calamari-clients/pull/55#issuecomment-59933816.

ChristinaMeno commented 10 years ago

@yanfali Thanks for the feedback. I created this PR because I was hoping github would let me show better diffs in the tickets I am creating to address the issues you raise. http://tracker.ceph.com/projects/calamari/issues?query_id=66

yanfali commented 10 years ago

@GregMeno sorry I don't have access to tracker any longer. :) Since I'm slacking off right now I suppose I could review it if you need some help.

ChristinaMeno commented 10 years ago

@yanfali Would you please make a recommendation on how to decide to choose a locale? It is my impression that YYMV by asking the browser. So I'm leaning toward asking the user and writing a cookie to remember it. What do you think?

If you think there is anything else worth recommending beyond what you've already said I would be happy to hear it.

CDS is coming up next week and I am trying to have a better set of what needs doing. I have tickets for each thing you've said so far.

yanfali commented 10 years ago

@GregMeno Actually the browser Accept-Language header is probably the most reliable and user friendly way of doing this. It specifies languages and falls back in that order. I would add support for zh-CN because that's what Dan appears to have done.

What you probably want to also do, is provide a user setting on the server to allow setting a default, which can be then be set via a cookie. It has to be done this way because cookies are not portable between browsers.

To support the cookie, you are going to need a way to store and set user preferences on the server per user. So this will require more work on the server side for this particular feature. You could also allow setting the language per browser by cookie, but this could lead to some confusion if the user switches browser or machine.

dmick commented 10 years ago

BTW, yanfali, you're welcome to have a tracker account if you wish.

yanfali commented 10 years ago

Yeah. That could come in handy if you need some feedback. Can you register on at gmail for me?