Style change question

[msambol]

If I changed the style to

apt_key: data="{{ lookup('file', '../../files/cephstable.asc') }}"
         state=present

instead of

apt_key: >
         data="{{ lookup('file', '../../files/cephstable.asc') }}"
         state=present

would you allow it?

[leseb]

Why would you want to do this? :) It depends, it you do this for the entire repo or not :) The more I look at ansbile repos the I see this kind of yaml syntax.

However I was more thinking at something like:

apt_key:
  data:"{{ lookup('file', '../../files/cephstable.asc') }}"
  state:present

[msambol]

I think that's a good compromise. :+1: I'll submit a PR later today..

[leseb]

This is a huge refactor so thanks in advance. Have a look at this repo: https://github.com/SamYaple/yaodu/tree/master/ansible/roles The syntax is a good example to follow.

[leseb]

@msambol Any update on this?

[msambol]

Got a little distracted with work stuff, I'll submit a PR asap.

[leseb]

No worries it's not urgent, I was just checking in while looking at the opened issues :)

[msambol]

I'm refactoring the monitor role, and it's getting stuck in start_monitor.yml at collect admin and bootstrap keys. When I run ceph-create-keys --id <hostname> manually on the node, I get the following error:

INFO:ceph-create-keys:ceph-mon admin socket not ready yet.
admin_socket: exception getting command descriptions: [Errno 2] No such file or directory

Have you seen this?

[leseb]

Looks like the monitor is not started thus there is not socket that can be called. Check that the monitor successfully started.

[leseb]

@msambol are you planning on working on the other roles as well? Thanks!

[msambol]

Yes! It's done for monitor... I'll submit soon.

[leseb]

@msambol awesome, looking forward to seeing your PR.

[leseb]

@msambol thanks a lot!