search

ceph / ceph-csi-operator

Kubernetes operator for managing the CephCSI plugins
Apache License 2.0
16 stars 18 forks source link

Makefile: fix panic in make test. #134

Closed obnoxxx closed 2 months ago

obnoxxx commented 2 months ago

Describe what this PR does

This stops make test from failing with a panic of the operator by making sure OPERATOR_NAMESPACE is set in the shell environment.

It does not fix make test completely though but lets it at least pass the first obstacle.

Provide some context for the reviewer

Is there anything that requires special attention

Do you have any questions? - no.

Is the change backward compatible? - should be.

Are there concerns around backward compatibility? - no.

Related issues

Mention any github issues relevant to this PR. Adding below line will help to auto close the issue once the PR is merged.

Resolves: #133

Future concerns

Checklist:

obnoxxx commented 2 months ago

@nb-ohad . @Madhu-1 FYI: I can't request review in this project. Asking you for review hereby. 😄

nb-ohad commented 2 months ago

@obnoxxx Please consider that we will need a similar patch for make run

Madhu-1 commented 2 months ago

@obnoxxx Please consider that we will need a similar patch for make run

@obnoxxx can you please the same for make run as well as part of this PR (different commit)

obnoxxx commented 2 months ago

@Madhu-1 wrote:

@obnoxxx Please consider that we will need a similar patch for make run

@obnoxxx can you please the same for make run as well as part of this PR (different commit)

done.

Madhu-1 commented 2 months ago

@obnoxxx you have requested for changes, PTAL

obnoxxx commented 2 months ago

@Madhu-1 wrote:

@obnoxxx you have requested for changes, PTAL

I think the only request still mentionned is @nb-ohad's request for the make run fix that is in fact addressed.

Madhu-1 commented 2 months ago

@obnoxxx you have requested for changes, PTAL

sorry for my mistake, @nb-ohad PTAL