Closed obnoxxx closed 2 months ago
This follows a recommendation on a previous PR:
https://github.com/ceph/ceph-csi-operator/pull/134#discussion_r1761416232
This change simplifies the code to conditionally set shell variables in the make targets run and test that was introduced in #134
run
test
Provide some context for the reviewer
No change in behavior is introduced, just a cleanup of the implementation that should make no difference to the user.
Do you have any questions?
no.
Is the change backward compatible?
should be.
Are there concerns around backward compatibility?
Provide any external context for the change, if any.
none
none, but see https://github.com/ceph/ceph-csi-operator/pull/134#discussion_r1761416232
no future concerns.
Checklist:
This follows a recommendation on a previous PR:
https://github.com/ceph/ceph-csi-operator/pull/134#discussion_r1761416232
Describe what this PR does
This change simplifies the code to conditionally set shell variables in the make targets
run
andtest
that was introduced in #134Provide some context for the reviewer
No change in behavior is introduced, just a cleanup of the implementation that should make no difference to the user.
Is there anything that requires special attention
Do you have any questions?
no.
Is the change backward compatible?
should be.
Are there concerns around backward compatibility?
no.
Provide any external context for the change, if any.
none
Related issues
none, but see https://github.com/ceph/ceph-csi-operator/pull/134#discussion_r1761416232
Future concerns
no future concerns.
Checklist: