ceph / ceph-csi-operator

Kubernetes operator for managing the CephCSI plugins
Apache License 2.0
16 stars 18 forks source link

Makefile: Simplify 'test' and 'run' targets a bit. #138

Closed obnoxxx closed 2 months ago

obnoxxx commented 2 months ago

This follows a recommendation on a previous PR:

https://github.com/ceph/ceph-csi-operator/pull/134#discussion_r1761416232

Describe what this PR does

This change simplifies the code to conditionally set shell variables in the make targets run and test that was introduced in #134

Provide some context for the reviewer

No change in behavior is introduced, just a cleanup of the implementation that should make no difference to the user.

Is there anything that requires special attention

Do you have any questions?

no.

Is the change backward compatible?

should be.

Are there concerns around backward compatibility?

no.

Provide any external context for the change, if any.

none

Related issues

none, but see https://github.com/ceph/ceph-csi-operator/pull/134#discussion_r1761416232

Future concerns

no future concerns.

Checklist: