Closed obnoxxx closed 1 month ago
This is marked as draft since it does not cover all points of #149 yet.
@Madhu-1 what remains is to add the stale workflow.
Any special requirements for this one or is it OK to use the rook workflow as a start?
https://github.com/rook/rook/blob/master/.github/workflows/stale.yaml
add some CI worjflows -> add some CI workflows
@parth-gr wrote:
add some CI worjflows -> add some CI workflows
good catch, thanks! fixed.
replying to myself:
@Madhu-1 what remains is to add the stale workflow.
Any special requirements for this one or is it OK to use the rook workflow as a start?
https://github.com/rook/rook/blob/master/.github/workflows/stale.yaml
I used that file as a basis after confirmation from @Madhu-1 on chat.
LGTM
marked ready for review since all items of #149 are addressed.
Describe what this PR does
This PR adds some github workflows to the CI as requested in #149
Is there anything that requires special attention
mod.check
make target to be easily invoked locally by developersDo you have any questions?
no questiions at this time.
Is the change backward compatible?
It should be backward compatible.
Provide any external context for the change, if any.
none.
Related issues
Mention any github issues relevant to this PR. Adding below line will help to auto close the issue once the PR is merged.
Fixes: #149
Future concerns
no future concerns currently.
Checklist: