ceph / ceph-csi-operator

Kubernetes operator for managing the CephCSI plugins
Apache License 2.0
16 stars 18 forks source link

remove kube-rbac-proxy container from deployment #154

Open leelavg opened 1 month ago

leelavg commented 1 month ago

csi-operator is not exporting any metrics exclusively and orchestrated csi already exports metrics on it's own which isn't tunneled through the operator.

kube-rbac-proxy prominently used to authenticate api access to metrics endpoint available on operator (manager) which isn't mandatory for us and this commit removes the same.

note that controller-runtime itself exports some metrics and this commit doesn't bind any port for controller-runtime which disables inbuilt metrics being available.

ref: https://book.kubebuilder.io/reference/metrics-reference

fixes: #119

leelavg commented 1 month ago

Testing:

> k logs ceph-csi-operator-controller-manager-7d64d95794-ww4jb --since 1m | tail -n3
2024-10-15T05:09:18Z    INFO    Starting workers        {"controller": "clientprofile", "controllerGroup": "csi.ceph.io", "controllerKind": "ClientProfile", "worker count": 1}
2024-10-15T05:09:18Z    INFO    Starting workers        {"controller": "clientprofilemapping", "controllerGroup": "csi.ceph.io", "controllerKind": "ClientProfileMapping", "worker count": 1}
2024-10-15T05:09:18Z    INFO    Starting workers        {"controller": "driver", "controllerGroup": "csi.ceph.io", "controllerKind": "Driver", "worker count": 1}
nb-ohad commented 1 month ago

@leelavg @Madhu-1 I would prefer if we would not just remove the code and configuration but make it optional. I can predict that very soon we will need to reintroduce this to support custom metrics.

nb-ohad commented 1 month ago

/hold

Madhu-1 commented 1 month ago

I can predict that very soon we will need to reintroduce this to support custom metrics.

@nb-ohad can you please provide details about it?