search

ceph / ceph-csi

CSI driver for Ceph
Apache License 2.0
1.27k stars 536 forks source link

Add liveness sidecar to ceph csi drivers #1096

Open humblec opened 4 years ago

humblec commented 4 years ago

The CSI livenessprobe is a sidecar container that monitors the health of the CSI driver and reports it to Kubernetes via the Liveness Probe mechanism. This enables Kubernetes to automatically detect issues with the driver and restart the pod to try and fix the issue.

humblec commented 4 years ago

@Madhu-1 fyi

mykaul commented 4 years ago

What is an unhealthy CSI driver? How we define it? Are there are any metrics we can use?

Madhu-1 commented 4 years ago

What is an unhealthy CSI driver? How we define it? Are there are any metrics we can use?

if the CSI driver is not sending any response to the GRPC request sent by liveness container it will be treated as unhealthy

how to use liveness is here https://github.com/kubernetes-csi/livenessprobe#usage

Madhu-1 commented 4 years ago

@humblec as we already have a liveness container which is built as part of ceph-csi can we expose an endpoint and use the same or do we need to use k8s-csi liveness

Madhu-1 commented 4 years ago

@humblec do we need it in release-3.0.0 milestone? or can we move it outside

Madhu-1 commented 4 years ago

Moving it to release-v3.1.0

Madhu-1 commented 4 years ago

@humblec can this be done in 3.1.0? or do we need to move it out to the next release?

humblec commented 4 years ago

@Yuggupta27 interested to work on this ?

pkalever commented 4 years ago

@humblec, I think @Yuggupta27 is busy with CI/e2e stuff, I'm happy to take over.

@Yuggupta27 feel free to jump in :-)

Thanks!

rjbrown57 commented 3 years ago

Any Updates on this?

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 3 years ago

This issue has been automatically closed due to inactivity. Please re-open if this still requires investigation.

Madhu-1 commented 1 year ago

This can be reworked using https://github.com/kubernetes/enhancements/issues/2727

Madhu-1 commented 3 months ago

This can be reworked using kubernetes/enhancements#2727

This currently works for GRPC server with port not with socket, we need to see if its possible or not.