ceph / ceph-csi

CSI driver for Ceph

Apache License 2.0

1.27k stars 536 forks source link

rbd: add ParentInTrash parameter in rbdImage struct (backport #4522) #4579

Closed mergify[bot] closed 5 months ago

mergify[bot] commented 5 months ago

rbd: add ParentInTrash parameter in rbdImage struct

This commit adds ParentInTrash parameter in rbdImage struct and makes use of it in getParent() function in order to avoid error in case the parent is present but in trash.
This commit modifies a test case to check creation of PVC-PVC clone of a restored PVC when parent snapshot is deleted.

Signed-off-by: Rakshith R rar@redhat.com

Describe what this PR does

Provide some context for the reviewer

Is there anything that requires special attention

Do you have any questions?

Is the change backward compatible?

Are there concerns around backward compatibility?

Provide any external context for the change, if any.

For example:

Kubernetes links that explain why the change is required
CSI spec related changes/catch-up that necessitates this patch
golang related practices that necessitates this change

Related issues

Mention any github issues relevant to this PR. Adding below line will help to auto close the issue once the PR is merged.

Fixes: #issue_number

Future concerns

List items that are not part of the PR and do not impact it's functionality, but are work items that can be taken up subsequently.

Checklist:

[ ] Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
[ ] Reviewed the developer guide on Submitting a Pull Request
[ ] Pending release notes updated with breaking and/or notable changes for the next major release.
[ ] Documentation has been updated, if necessary.
[ ] Unit tests have been added, if necessary.
[ ] Integration tests have been added, if necessary.

Show available bot commands

These commands are normally not required, but in case of issues, leave any of the following bot commands in an otherwise empty comment in this PR: * `/retest ci/centos/`: retest the `` after unrelated failure (please report the failure too!)

This is an automatic backport of pull request #4522 done by Mergify.

ceph-csi-bot commented 5 months ago

/test ci/centos/upgrade-tests-cephfs

ceph-csi-bot commented 5 months ago

/test ci/centos/upgrade-tests-rbd

ceph-csi-bot commented 5 months ago

/test ci/centos/k8s-e2e-external-storage/1.26

ceph-csi-bot commented 5 months ago

/test ci/centos/mini-e2e-helm/k8s-1.26

ceph-csi-bot commented 5 months ago

/test ci/centos/mini-e2e/k8s-1.26

ceph-csi-bot commented 5 months ago

/test ci/centos/k8s-e2e-external-storage/1.27

ceph-csi-bot commented 5 months ago

/test ci/centos/mini-e2e-helm/k8s-1.27

ceph-csi-bot commented 5 months ago

/test ci/centos/mini-e2e/k8s-1.27

ceph-csi-bot commented 5 months ago

/test ci/centos/k8s-e2e-external-storage/1.28

ceph-csi-bot commented 5 months ago

/test ci/centos/mini-e2e-helm/k8s-1.28

ceph-csi-bot commented 5 months ago

/test ci/centos/k8s-e2e-external-storage/1.29

ceph-csi-bot commented 5 months ago

/test ci/centos/mini-e2e/k8s-1.28

ceph-csi-bot commented 5 months ago

/test ci/centos/mini-e2e-helm/k8s-1.29

ceph-csi-bot commented 5 months ago

/test ci/centos/mini-e2e/k8s-1.29

nixpanic commented 5 months ago

@mergifyio refresh

mergify[bot] commented 5 months ago

refresh

✅ Pull request refreshed

nixpanic commented 5 months ago

@mergifyio requeue

mergify[bot] commented 5 months ago

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

nixpanic commented 5 months ago

@mergifyio refresh

mergify[bot] commented 5 months ago

refresh

✅ Pull request refreshed

nixpanic commented 5 months ago

@mergifyio rebase

mergify[bot] commented 5 months ago

rebase

✅ Nothing to do for rebase action

nixpanic commented 5 months ago

@mergifyio queue

mergify[bot] commented 5 months ago

queue

🛑 The pull request has been removed from the queue `default`

The queue conditions cannot be satisfied due to failing checks. You can take a look at `Queue: Embarked in merge queue` check runs for more details. In case of a failure due to a flaky test, you should first retrigger the CI. Then, re-embark the pull request into the merge queue by posting the comment `@mergifyio refresh` on the pull request.

nixpanic commented 5 months ago

@mergifyio requeue

mergify[bot] commented 5 months ago

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

nixpanic commented 5 months ago

I fail to see why this rule is not sufficient:

Possibly this is because ci/centos/k8s-e2e-external-storage/1.26 failed, but that one should not be required :thinking:

Madhu-1 commented 5 months ago

this says it required 1.26

Madhu-1 commented 5 months ago

@mergifyio refresh

mergify[bot] commented 5 months ago

refresh

✅ Pull request refreshed

Madhu-1 commented 5 months ago

@mergifyio dequeue

mergify[bot] commented 5 months ago

dequeue

☑️ The pull request is not queued

Madhu-1 commented 5 months ago

@mergifyio refresh

mergify[bot] commented 5 months ago

refresh

✅ Pull request refreshed

Madhu-1 commented 5 months ago

/test ci/centos/k8s-e2e-external-storage/1.26