build: use Go 1.22 - Githubissues

ceph / ceph-csi

CSI driver for Ceph

Apache License 2.0

1.2k stars 528 forks source link

build: use Go 1.22 #4593

Closed nixpanic closed 2 months ago

nixpanic commented 2 months ago

Kubernetes 1.30 packages require Go 1.22 or newer.

With a new Go version, golangci-lint reports more issues, these are addressed as well.

golangci-lint reports these:

The copy of the 'for' variable "kmsID" can be deleted (Go 1.22+)
(copyloopvar)

golangci-lint warns about this:

for loop can be changed to use an integer range (Go 1.22+)
(intrange)

gosec warns about it like this:

G601: Implicit memory aliasing in for loop. (gosec)

Related-to: #4569

nixpanic commented 2 months ago

@mergifyio queue

mergify[bot] commented 2 months ago

queue

🛑 The pull request has been removed from the queue `default`

The queue conditions cannot be satisfied due to failing checks. You can take a look at `Queue: Embarked in merge queue` check runs for more details. In case of a failure due to a flaky test, you should first retrigger the CI. Then, re-embark the pull request into the merge queue by posting the comment `@mergifyio refresh` on the pull request.