Thingee commented 1 month ago

Describe what this PR does

Removing JoinError in favor of fmt.Errorf

Is there anything that requires special attention

No

Related issues

None

Future concerns

List items that are not part of the PR and do not impact it's functionality, but are work items that can be taken up subsequently.

Checklist:

[x] Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
[ ] Reviewed the developer guide on Submitting a Pull Request
[x] Pending release notes updated with breaking and/or notable changes for the next major release.
[x] Documentation has been updated, if necessary.
[x] Unit tests have been added, if necessary.
[x] Integration tests have been added, if necessary.

Show available bot commands

These commands are normally not required, but in case of issues, leave any of the following bot commands in an otherwise empty comment in this PR: * `/retest ci/centos/`: retest the `` after unrelated failure (please report the failure too!)

Madhu-1 commented 1 month ago

https://github.com/ceph/ceph-csi/pull/4622 should fix the CI problem.

Rakshith-R commented 1 month ago

@mergifyio queue

mergify[bot] commented 1 month ago

queue

🛑 The pull request has been removed from the queue `default`

The pull request can't be updated. You can take a look at `Queue: Embarked in merge queue` check runs for more details. In case of a failure due to a flaky test, you should first retrigger the CI. Then, re-embark the pull request into the merge queue by posting the comment `@mergifyio refresh` on the pull request.

Rakshith-R commented 1 month ago

@mergifyio rebase

mergify[bot] commented 1 month ago

rebase

✅ Branch has been successfully rebased

Rakshith-R commented 1 month ago

@mergifyio queue

mergify[bot] commented 1 month ago

queue