ceph / ceph-csi

CSI driver for Ceph
Apache License 2.0
1.19k stars 528 forks source link

cephfs: upgrade fscrypt version to fix concurrency issue #4609

Closed NymanRobin closed 1 month ago

NymanRobin commented 1 month ago

In older versions of fscrypt there is a race condition when multiple encrypted cephfs instances are deployed simultaneously. This PR upgrades the fscrypt version to the latest version that contains a fix to the concurrency issue, used the commit sha as we cannot know when the next official release will happen from fscrypt side.

This PR fixes: #4592

Madhu-1 commented 1 month ago

@mergifyio queue

mergify[bot] commented 1 month ago

queue

🛑 The pull request has been removed from the queue default

The pull request can't be updated. You can take a look at `Queue: Embarked in merge queue` check runs for more details. In case of a failure due to a flaky test, you should first retrigger the CI. Then, re-embark the pull request into the merge queue by posting the comment `@mergifyio refresh` on the pull request.
Madhu-1 commented 1 month ago

@mergifyio rebase

mergify[bot] commented 1 month ago

rebase

❌ Pull request can't be updated with latest base branch changes

Mergify needs the author permission to update the base branch of the pull request. @Nordix needs to [authorize modification on its head branch](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork).
Madhu-1 commented 1 month ago

rebase

❌ Pull request can't be updated with latest base branch changes

Mergify needs the author permission to update the base branch of the pull request. @Nordix needs to authorize modification on its head branch.

@NymanRobin can you please check this one?

NymanRobin commented 1 month ago

Sure, I will check @Madhu-1

NymanRobin commented 1 month ago

I did a manual rebase, do you think that will do it? @Madhu-1

Madhu-1 commented 1 month ago

@mergifyio queue

mergify[bot] commented 1 month ago

queue

🟠 Waiting for conditions to match

- [ ] any of: [🔀 queue conditions] - [ ] all of: [📌 queue conditions of queue `default`] - [ ] `#approved-reviews-by>=2` [🛡 GitHub branch protection] - [X] `#changes-requested-reviews-by=0` [🛡 GitHub branch protection] - [X] `-draft` [📌 queue requirement] - [X] any of: [📌 queue -> configuration change requirements] - [X] `-mergify-configuration-changed` - [ ] `check-success=Configuration changed`
Madhu-1 commented 1 month ago

I did a manual rebase, do you think that will do it? @Madhu-1

i triggered bot, lets see how it goes :)

Rakshith-R commented 1 month ago

@Mergifyio queue

mergify[bot] commented 1 month ago

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks. You can take a look at `Queue: Embarked in merge queue` check runs for more details. In case of a failure due to a flaky test, you should first retrigger the CI. Then, re-embark the pull request into the merge queue by posting the comment `@mergifyio refresh` on the pull request.
ceph-csi-bot commented 1 month ago

/test ci/centos/upgrade-tests-cephfs

ceph-csi-bot commented 1 month ago

/test ci/centos/upgrade-tests-rbd

ceph-csi-bot commented 1 month ago

/test ci/centos/k8s-e2e-external-storage/1.27

ceph-csi-bot commented 1 month ago

/test ci/centos/k8s-e2e-external-storage/1.29

ceph-csi-bot commented 1 month ago

/test ci/centos/k8s-e2e-external-storage/1.28

ceph-csi-bot commented 1 month ago

/test ci/centos/mini-e2e-helm/k8s-1.29

ceph-csi-bot commented 1 month ago

/test ci/centos/mini-e2e-helm/k8s-1.27

ceph-csi-bot commented 1 month ago

/test ci/centos/mini-e2e-helm/k8s-1.28

ceph-csi-bot commented 1 month ago

/test ci/centos/k8s-e2e-external-storage/1.30

ceph-csi-bot commented 1 month ago

/test ci/centos/mini-e2e/k8s-1.29

ceph-csi-bot commented 1 month ago

/test ci/centos/mini-e2e/k8s-1.27

ceph-csi-bot commented 1 month ago

/test ci/centos/mini-e2e/k8s-1.28

ceph-csi-bot commented 1 month ago

/test ci/centos/mini-e2e-helm/k8s-1.30

ceph-csi-bot commented 1 month ago

/test ci/centos/mini-e2e/k8s-1.30

NymanRobin commented 1 month ago

Looks like there was a failure related to the network in one of tests? Would it be possible to retrigger it?

Error: Error downloading packages:
  Curl error (7): Couldn't connect to server for http://mirrorlist.centos.org/?release=8-stream&arch=x86_64&repo=AppStream&infra=ec2 [Failed to connect to mirrorlist.centos.org port 80: Connection refused]
script returned exit code 1

EDIT: Seems there was also another test failure that I am not exactly sure of what caused it

Rakshith-R commented 1 month ago

@iPraveenParihar please check and restart the tests

iPraveenParihar commented 1 month ago

/retest ci/centos/mini-e2e/k8s-1.27

iPraveenParihar commented 1 month ago

/retest ci/centos/mini-e2e/k8s-1.28