rebase: bump sigs.k8s.io/controller-runtime from 0.17.3 to 0.18.2 in the k8s-dependencies group across 1 directory

dependabot[bot] commented 1 month ago

Bumps the k8s-dependencies group with 1 update in the / directory: sigs.k8s.io/controller-runtime.

Updates sigs.k8s.io/controller-runtime from 0.17.3 to 0.18.2

Release notes

Sourced from sigs.k8s.io/controller-runtime's releases.

v0.18.2

What's Changed

🐛 Reintroduce AddMetricsServerExtraHandler on manager by @k8s-infra-cherrypick-robot in kubernetes-sigs/controller-runtime#2817

Full Changelog: https://github.com/kubernetes-sigs/controller-runtime/compare/v0.18.1...v0.18.2

v0.18.1

What's Changed

[release-0.18] :bug: Cache: Fix label defaulting of byObject when namespaces are configured by @k8s-infra-cherrypick-robot in kubernetes-sigs/controller-runtime#2808

[release-0.18] 🐛 correct kind source type by @k8s-infra-cherrypick-robot in kubernetes-sigs/controller-runtime#2809

Full Changelog: https://github.com/kubernetes-sigs/controller-runtime/compare/v0.18.0...v0.18.1

v0.18.0

:warning: Breaking Changes

Bump to k8s.io/* v1.30 (#2693 #2754 #2765 #2776 #2786)

Remove deprecated v1alpha1.ControllerManagerConfiguration (#2648)

admission.Decoder is now an interface (#2736)

Source, Event, Predicate, Handler: Add generics support (#2783 #2796)

client: Fix SubResourceCreateOptions signature in subresource client (#2766)

:sparkles: New Features

cache: Add TransformStripManagedFields transform func (#2791)

client: Add client.WithFieldOwner to configure client-wide FieldManager (#2771 #2777)

controller: Add NewQueue option (#2767)

manager: Export HTTP server runnable implementation (#2473)

metrics/server: Add ListenConfig option (#2519)

:bug: Bug Fixes

builder/webhook: Return error if For() is used multiple times (#2740)

cache: Keep selectors when byObject.Namespaces is defaulted (#2747)

cache: Prevent race when informers are started more than once (#2758)

fake client: Allow fakeclient to patch CR with no resourceVersion (#2725)

fake client: Do not consider an apply patch to be a strategic merge patch (#2679)

manager: Prevent leader election when shutting down a non-elected manager (#2724)

manager: Runnable group should check if stopped before enqueueing (#2757)

restmapper: Clean restmapper cache if a version is notFound (#2663)

restmapper: Fix cache invalidation (#2687)

:seedling: Others

ci: Add OSSF scorecard action (#2714)

ci: Improve github actions dependencies versions and permissions (#2715)

ci: Pin checkout action in golangci-lint action, bump checkout action, use consistent tag format (#2729)

ci: Update golangci-lint to v1.57.2 (#2708 #2751)

... (truncated)

Commits

834905b Merge pull request #2817 from k8s-infra-cherrypick-robot/cherry-pick-2813-to-...
6396a49 Reintroduce AddMetricsExtraHandler on manager
cd2885e Merge pull request #2809 from k8s-infra-cherrypick-robot/cherry-pick-2806-to-...
06acde3 🐛 correct kind source type
d6feaae Merge pull request #2808 from k8s-infra-cherrypick-robot/cherry-pick-2805-to-...
87cae4c bug: Cache: Fix label defaulting of byObject when namespaces are configured
ed81fa6 Merge pull request #2796 from alvaroaleman/mark
b35cd6b :book: Mark Typed Handlers as experimental
b74908f Merge pull request #2793 from kubernetes-sigs/dependabot/github_actions/actio...
a9db208 Merge pull request #2794 from kubernetes-sigs/dependabot/github_actions/actio...
Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore ` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore ` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore ` will remove the ignore condition of the specified dependency and ignore conditions

Madhu-1 commented 1 month ago

/test ci/centos/mini-e2e/k8s-1.28

Madhu-1 commented 1 month ago

/test ci/centos/mini-e2e/k8s-1.28

Madhu-1 commented 1 month ago

/test ci/centos/mini-e2e/k8s-1.28

iPraveenParihar commented 1 month ago

/test ci/centos/mini-e2e/k8s-1.28

iPraveenParihar commented 1 month ago

/test ci/centos/mini-e2e/k8s-1.27

iPraveenParihar commented 1 month ago

verifying that ceph-fuse recovery works for new pods test is failing, tested locally,

pod describe

  Type     Reason     Age                 From               Message
  ----     ------     ----                ----               -------
  Normal   Scheduled  21m                 default-scheduler  Successfully assigned test/csi-cephfs-demo-depl-7d55fdc599-szfb5 to c1
  Normal   Pulled     21m                 kubelet            Successfully pulled image "docker.io/library/nginx:latest" in 2.292636931s (2.292676293s including waiting)
  Normal   Pulled     21m                 kubelet            Successfully pulled image "docker.io/library/nginx:latest" in 2.187885572s (2.187891578s including waiting)
  Normal   Pulled     20m                 kubelet            Successfully pulled image "docker.io/library/nginx:latest" in 2.190849647s (2.190855193s including waiting)
  Warning  Failed     20m (x4 over 21m)   kubelet            Error: failed to start container "web-server": Error response from daemon: error while creating mount source path '/var/lib/kubelet/pods/8c66d061-189a-4b20-bd45-e14d5b3ab2e3/volumes/kubernetes.io~csi/pvc-ad9c8917-8c50-456f-911b-37a6deb03f91/mount': mkdir /var/lib/kubelet/pods/8c66d061-189a-4b20-bd45-e14d5b3ab2e3/volumes/kubernetes.io~csi/pvc-ad9c8917-8c50-456f-911b-37a6deb03f91/mount: file exists
  Normal   Pulled     20m                 kubelet            Successfully pulled image "docker.io/library/nginx:latest" in 2.387547365s (2.387572149s including waiting)
  Normal   Pulling    19m (x5 over 21m)   kubelet            Pulling image "docker.io/library/nginx:latest"
  Normal   Created    19m (x5 over 21m)   kubelet            Created container web-server
  Normal   Pulled     19m                 kubelet            Successfully pulled image "docker.io/library/nginx:latest" in 2.334123775s (2.334129399s including waiting)
  Warning  BackOff    59s (x88 over 20m)  kubelet            Back-off restarting failed container web-server in pod csi-cephfs-demo-depl-7d55fdc599-szfb5_test(8c66d061-189a-4b20-bd45-e14d5b3ab2e3)

after killall -9 ceph-fuse both staging and target path seems to be corrupted?

$ sudo ls -l /var/lib/kubelet/plugins/kubernetes.io/csi/rook-ceph.cephfs.csi.ceph.com/c57e487f74b05bade7ab81d4ed500cededd686dbcfab02b9cea5600d371b9c6f
ls: cannot access '/var/lib/kubelet/plugins/kubernetes.io/csi/rook-ceph.cephfs.csi.ceph.com/c57e487f74b05bade7ab81d4ed500cededd686dbcfab02b9cea5600d371b9c6f/globalmount': Transport endpoint is not connected
total 4
d????????? ? ?    ?      ?            ? globalmount
-rw-r--r-- 1 root root 138 May 22 08:48 vol_data.json
$ sudo ls -l /var/lib/kubelet/pods/8c66d061-189a-4b20-bd45-e14d5b3ab2e3/volumes/kubernetes.io~csi/pvc-ad9c8917-8c50-456f-911b-37a6deb03f91
ls: cannot access '/var/lib/kubelet/pods/8c66d061-189a-4b20-bd45-e14d5b3ab2e3/volumes/kubernetes.io~csi/pvc-ad9c8917-8c50-456f-911b-37a6deb03f91/mount': Transport endpoint is not connected
total 4
d????????? ? ?    ?      ?            ? mount
-rw-r--r-- 1 root root 330 May 22 08:50 vol_data.json

But stating path is returned as MOUNTED and target path as NOT_MOUNTED and fuse-recovery is not attempted.

I0522 08:50:44.714587       1 fuserecovery.go:92] ID: 21 Req-ID: 0001-0009-rook-ceph-0000000000000001-0b76a303-5d4a-4036-b152-b1feef05f8fe cephfs: staging target path /var/lib/kubelet/plugins/kubernetes.io/csi/rook-ceph.cephfs.csi.ceph.com/c57e487f74b05bade7ab81d4ed500cededd686dbcfab02b9cea5600d371b9c6f/globalmount is MOUNTED
I0522 08:50:44.714650       1 fuserecovery.go:98] ID: 21 Req-ID: 0001-0009-rook-ceph-0000000000000001-0b76a303-5d4a-4036-b152-b1feef05f8fe cephfs: target path /var/lib/kubelet/pods/8c66d061-189a-4b20-bd45-e14d5b3ab2e3/volumes/kubernetes.io~csi/pvc-ad9c8917-8c50-456f-911b-37a6deb03f91/mount is NOT_MOUNTED

using image from devel branch (which has k8s.io/mount-utils v0.29.3) and issue is gone, from logs you can see the stating path is returned as CORRUPTED and target path as NOT_MOUNTED and fuse-recovery is attempted and succeeded

I0522 09:56:47.612507       1 fuserecovery.go:92] ID: 16 Req-ID: 0001-0009-rook-ceph-0000000000000001-43fb5753-00c3-4afb-87b5-f4e255e10c8a cephfs: staging target path /var/lib/kubelet/plugins/kubernetes.io/csi/rook-ceph.cephfs.csi.ceph.com/8a78178247287601fcceabc0de70fa12ce5370938dad84960b5dc47c902bed77/globalmount is CORRUPTED
I0522 09:56:47.612525       1 fuserecovery.go:98] ID: 16 Req-ID: 0001-0009-rook-ceph-0000000000000001-43fb5753-00c3-4afb-87b5-f4e255e10c8a cephfs: target path /var/lib/kubelet/pods/bf47481a-9771-4927-9a4e-fe5284a90865/volumes/kubernetes.io~csi/pvc-b6afe4f7-72f2-4c3e-ab44-9770eb2de568/mount is NOT_MOUNTED
W0522 09:56:47.612563       1 fuserecovery.go:110] ID: 16 Req-ID: 0001-0009-rook-ceph-0000000000000001-43fb5753-00c3-4afb-87b5-f4e255e10c8a cephfs: mount problem detected when publishing a volume: /var/lib/kubelet/plugins/kubernetes.io/csi/rook-ceph.cephfs.csi.ceph.com/8a78178247287601fcceabc0de70fa12ce5370938dad84960b5dc47c902bed77/globalmount is CORRUPTED, /var/lib/kubelet/pods/bf47481a-9771-4927-9a4e-fe5284a90865/volumes/kubernetes.io~csi/pvc-b6afe4f7-72f2-4c3e-ab44-9770eb2de568/mount is NOT_MOUNTED; attempting recovery
I0522 09:56:47.622236       1 omap.go:89] ID: 16 Req-ID: 0001-0009-rook-ceph-0000000000000001-43fb5753-00c3-4afb-87b5-f4e255e10c8a got omap values: (pool="myfs-metadata", namespace="csi", name="csi.volume.43fb5753-00c3-4afb-87b5-f4e255e10c8a"): map[csi.imagename:csi-vol-43fb5753-00c3-4afb-87b5-f4e255e10c8a csi.volname:pvc-b6afe4f7-72f2-4c3e-ab44-9770eb2de568 csi.volume.owner:test]

I suspect issue with k8s.io/mount-utils > v0.29.3. However, I don't see any similar open issue.

cc @Rakshith-R

iPraveenParihar commented 1 month ago

replacing, k8s.io/mount-utils => k8s.io/mount-utils v0.29.3

iPraveenParihar commented 1 month ago

/test ci/centos/mini-e2e/k8s-1.28

iPraveenParihar commented 1 month ago

replacing, k8s.io/mount-utils => k8s.io/mount-utils v0.29.3

this works!, So, will add a TODO: update once fixed in mount-utils and visit later? @Madhu-1

Madhu-1 commented 1 month ago

replacing, k8s.io/mount-utils => k8s.io/mount-utils v0.29.3

this works!, So, will add a TODO: update once fixed in mount-utils and visit later? @Madhu-1

@iPraveenParihar Thank you, lets get it merged and we will revisit mount-utils, lets check what is changed in mount-utils release notes.

Rakshith-R commented 1 month ago

@mergifyio queue

mergify[bot] commented 1 month ago

queue

🛑 The pull request has been removed from the queue `default`

The queue conditions cannot be satisfied due to failing checks. You can take a look at `Queue: Embarked in merge queue` check runs for more details. In case of a failure due to a flaky test, you should first retrigger the CI. Then, re-embark the pull request into the merge queue by posting the comment `@mergifyio refresh` on the pull request.