search

ceph / ceph-csi

CSI driver for Ceph
Apache License 2.0
1.27k stars 536 forks source link

ci: fix local run failure of go-test due to missing config file #4620

Closed mayankpall closed 4 months ago

mayankpall commented 4 months ago

ci: fix local run failure of go-test due to missing config file

The issue was caused by the config.json file path not being properly set up during local test runs, leading to permission errors and missing file errors. To resolve this, the configuration file path is now created in a temporary test directory using t.TempDir(), similar to other tests.

Signed-off-by: Mayank Pal mayankpal9654@gmail.com

Fixes: #4617

iPraveenParihar commented 4 months ago

@mayankpall, please format your commit message as per commit rules documented here

mayankpall commented 4 months ago

@iPraveenParihar is it fine now ?

iPraveenParihar commented 4 months ago

@iPraveenParihar is it fine now ?

@mayankpall, I think you have changed the title and PR description. Thats good! But what I meant was your commit title. Which I can see now is fixed ceph#4617

can you change that may be something like rbd: use temp dir for unit tests?

mayankpall commented 4 months ago

@iPraveenParihar , hope now its correct

iPraveenParihar commented 4 months ago

@iPraveenParihar , hope now its correct

please format commit message as per - 

The first line is the subject and should be no longer than 70 characters, the second line is always blank, and other lines should be wrapped at 80 characters.

and squash your commits