ceph / ceph-csi

CSI driver for Ceph
Apache License 2.0
1.19k stars 528 forks source link

ci: Use temporary directory for unit tests #4626

Closed mayankpall closed 1 month ago

mayankpall commented 1 month ago

ci: Use temporary directory for unit tests

This commit implements the use of a temporary directory for unit tests in order to ensure a clean and isolated environment for testing purposes.

Signed-off-by: Mayank Pal mayankpal9654@gmail.com

Fixes #4617

mayankpall commented 1 month ago

@iPraveenParihar Hopefully now it meets the requirement

iPraveenParihar commented 1 month ago

@iPraveenParihar Hopefully now it meets the requirement

@mayankpall, please look at the following error and update the commit body.

✖ body's lines must not be longer than 80 characters [body-max-line-length]

mayankpall commented 1 month ago
Screenshot 2024-05-19 at 4 45 26 PM

@iPraveenParihar edited it to shortest as possible.

mayankpall commented 1 month ago

@iPraveenParihar all checks have passed

mayankpall commented 1 month ago

@Madhu-1 removed err = os.Mkdir("/etc/ceph-csi-config", 0o600)

mayankpall commented 1 month ago

@Madhu-1 removed and squashed all the commits

iPraveenParihar commented 1 month ago

@Madhu-1, can we skip e2e tests for this PR? Since changes are in unit tests?

Madhu-1 commented 1 month ago

@Madhu-1, can we skip e2e tests for this PR? Since changes are in unit tests?

yes that make sense, we can skip multi-arch buil and E2E for this kind of PR's

iPraveenParihar commented 1 month ago

@Mergifyio queue

mergify[bot] commented 1 month ago

queue

🛑 The pull request has been removed from the queue default

The pull request can't be updated. You can take a look at `Queue: Embarked in merge queue` check runs for more details. In case of a failure due to a flaky test, you should first retrigger the CI. Then, re-embark the pull request into the merge queue by posting the comment `@mergifyio refresh` on the pull request.
iPraveenParihar commented 1 month ago

@mergifyio rebase

mergify[bot] commented 1 month ago

rebase

✅ Branch has been successfully rebased

iPraveenParihar commented 1 month ago

@Mergifyio queue

mergify[bot] commented 1 month ago

queue

🛑 The pull request has been removed from the queue default

The pull request can't be updated. You can take a look at `Queue: Embarked in merge queue` check runs for more details. In case of a failure due to a flaky test, you should first retrigger the CI. Then, re-embark the pull request into the merge queue by posting the comment `@mergifyio refresh` on the pull request.
iPraveenParihar commented 1 month ago

@Mergifyio refresh

mergify[bot] commented 1 month ago

refresh

✅ Pull request refreshed

iPraveenParihar commented 1 month ago

@Mergifyio queue default

mergify[bot] commented 1 month ago

queue default

🛑 The pull request has been removed from the queue default

The pull request can't be updated. You can take a look at `Queue: Embarked in merge queue` check runs for more details. In case of a failure due to a flaky test, you should first retrigger the CI. Then, re-embark the pull request into the merge queue by posting the comment `@mergifyio refresh` on the pull request.
iPraveenParihar commented 1 month ago

@Rakshith-R, can you take look at this?

Mergifyio can't queue due to

The merge queue pull request can't be updated
Details:

Unable to update: user mayankpall is unknown.
Rakshith-R commented 1 month ago

@mergifyio rebase

mergify[bot] commented 1 month ago

rebase

✅ Branch has been successfully rebased

Rakshith-R commented 1 month ago

@mergifyio queue

mergify[bot] commented 1 month ago

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at *822794c242b2de325000e52bbc893c40026c2617*
ceph-csi-bot commented 1 month ago

/test ci/centos/upgrade-tests-cephfs

ceph-csi-bot commented 1 month ago

/test ci/centos/k8s-e2e-external-storage/1.29

ceph-csi-bot commented 1 month ago

/test ci/centos/k8s-e2e-external-storage/1.28

ceph-csi-bot commented 1 month ago

/test ci/centos/k8s-e2e-external-storage/1.27

ceph-csi-bot commented 1 month ago

/test ci/centos/upgrade-tests-rbd

ceph-csi-bot commented 1 month ago

/test ci/centos/mini-e2e-helm/k8s-1.29

ceph-csi-bot commented 1 month ago

/test ci/centos/mini-e2e-helm/k8s-1.28

ceph-csi-bot commented 1 month ago

/test ci/centos/mini-e2e-helm/k8s-1.27

ceph-csi-bot commented 1 month ago

/test ci/centos/mini-e2e/k8s-1.29

ceph-csi-bot commented 1 month ago

/test ci/centos/mini-e2e/k8s-1.28

ceph-csi-bot commented 1 month ago

/test ci/centos/mini-e2e/k8s-1.27

ceph-csi-bot commented 1 month ago

/test ci/centos/k8s-e2e-external-storage/1.30

ceph-csi-bot commented 1 month ago

/test ci/centos/mini-e2e-helm/k8s-1.30

ceph-csi-bot commented 1 month ago

/test ci/centos/mini-e2e/k8s-1.30