testwill commented 4 months ago

Describe what this PR does

close /.snap directory

Is there anything that requires special attention

Do you have any questions?

Is the change backward compatible?

Are there concerns around backward compatibility?

Provide any external context for the change, if any.

For example:

Kubernetes links that explain why the change is required
CSI spec related changes/catch-up that necessitates this patch
golang related practices that necessitates this change

Related issues

Mention any github issues relevant to this PR. Adding below line will help to auto close the issue once the PR is merged.

Fixes: #issue_number

Future concerns

List items that are not part of the PR and do not impact it's functionality, but are work items that can be taken up subsequently.

Checklist:

[ ] Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
[ ] Reviewed the developer guide on Submitting a Pull Request
[ ] Pending release notes updated with breaking and/or notable changes for the next major release.
[ ] Documentation has been updated, if necessary.
[ ] Unit tests have been added, if necessary.
[ ] Integration tests have been added, if necessary.

Show available bot commands

These commands are normally not required, but in case of issues, leave any of the following bot commands in an otherwise empty comment in this PR: * `/retest ci/centos/`: retest the `` after unrelated failure (please report the failure too!)

iPraveenParihar commented 4 months ago

@testwill, please format your commit message as per commit rules documented here

And also, the PR description

Rakshith-R commented 4 months ago

@mergifyio rebase @mergifyio queue

mergify[bot] commented 4 months ago

rebase

✅ Branch has been successfully rebased

Rakshith-R commented 4 months ago

@Mergifyio queue

mergify[bot] commented 4 months ago

queue

🛑 The pull request has been removed from the queue `default`

The queue conditions cannot be satisfied due to failing checks. You can take a look at `Queue: Embarked in merge queue` check runs for more details. In case of a failure due to a flaky test, you should first retrigger the CI. Then, re-embark the pull request into the merge queue by posting the comment `@mergifyio refresh` on the pull request.

ceph-csi-bot commented 4 months ago

/test ci/centos/k8s-e2e-external-storage/1.27

ceph-csi-bot commented 4 months ago

/test ci/centos/upgrade-tests-cephfs

ceph-csi-bot commented 4 months ago

/test ci/centos/mini-e2e-helm/k8s-1.27

ceph-csi-bot commented 4 months ago

/test ci/centos/upgrade-tests-rbd

ceph-csi-bot commented 4 months ago

/test ci/centos/k8s-e2e-external-storage/1.30

ceph-csi-bot commented 4 months ago

/test ci/centos/mini-e2e/k8s-1.27

ceph-csi-bot commented 4 months ago

/test ci/centos/k8s-e2e-external-storage/1.29

ceph-csi-bot commented 4 months ago

/test ci/centos/mini-e2e-helm/k8s-1.30

ceph-csi-bot commented 4 months ago

/test ci/centos/k8s-e2e-external-storage/1.28

ceph-csi-bot commented 4 months ago

/test ci/centos/mini-e2e/k8s-1.30

ceph-csi-bot commented 4 months ago

/test ci/centos/mini-e2e-helm/k8s-1.29

ceph-csi-bot commented 4 months ago

/test ci/centos/mini-e2e-helm/k8s-1.28

ceph-csi-bot commented 4 months ago

/test ci/centos/mini-e2e/k8s-1.29

ceph-csi-bot commented 4 months ago

/test ci/centos/mini-e2e/k8s-1.28

Rakshith-R commented 4 months ago

@testwill, please format your commit message as per commit rules documented here

And also, the PR description

@testwill Can you please sign off your commit as well ?

please refer to https://github.com/ceph/ceph-csi/pull/4631/checks?check_run_id=25443599508

Sorry, missed that test failure before adding queue command :facepalm:

Rakshith-R commented 4 months ago

@mergifyio rebase

mergify[bot] commented 4 months ago

rebase

✅ Branch has been successfully rebased

Rakshith-R commented 4 months ago

@Mergifyio rebase

Oh, I see rebase command is causing the problem with DCO check probably a new issue.

@testwill Can you please rebase it to latest manually ?

testwill commented 4 months ago

@Mergifyio rebase

Oh, I see rebase command is causing the problem with DCO check probably a new issue.

@testwill Can you please rebase it to latest manually ?

ok

Rakshith-R commented 4 months ago

https://github.com/ceph/ceph-csi/pull/4631/checks?check_run_id=25444465486 The error also seems to point to two different names ?

Commit sha: 0d42f1e, Author: guangwu, Committer: Rakshith-R; Expected "guangwu guoguangwug@gmail.com", but got "guoguangwu guoguangwug@gmail.com".

testwill commented 4 months ago

https://github.com/ceph/ceph-csi/pull/4631/checks?check_run_id=25444465486 The error also seems to point to two different names ?

Commit sha: 0d42f1e, Author: guangwu, Committer: Rakshith-R; Expected "guangwu guoguangwug@gmail.com", but got "guoguangwu guoguangwug@gmail.com".

I modified it

Rakshith-R commented 4 months ago

/test ci/centos/mini-e2e-helm/k8s-1.29

Rakshith-R commented 4 months ago

https://github.com/ceph/ceph-csi/pull/4631/checks?check_run_id=25444465486 The error also seems to point to two different names ?

Commit sha: 0d42f1e, Author: guangwu, Committer: Rakshith-R; Expected "guangwu guoguangwug@gmail.com", but got "guoguangwu guoguangwug@gmail.com".

I modified it

Thanks

Rakshith-R commented 4 months ago

@mergifyio queue

mergify[bot] commented 4 months ago

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at *9574fa881bc6e2840ebb135d49fef0c1c5c84b9a*

ceph-csi-bot commented 4 months ago

/test ci/centos/k8s-e2e-external-storage/1.27

ceph-csi-bot commented 4 months ago

/test ci/centos/upgrade-tests-cephfs

ceph-csi-bot commented 4 months ago

/test ci/centos/mini-e2e-helm/k8s-1.27

ceph-csi-bot commented 4 months ago

/test ci/centos/upgrade-tests-rbd

ceph-csi-bot commented 4 months ago

/test ci/centos/mini-e2e/k8s-1.27

ceph-csi-bot commented 4 months ago

/test ci/centos/k8s-e2e-external-storage/1.30

ceph-csi-bot commented 4 months ago

/test ci/centos/k8s-e2e-external-storage/1.28

ceph-csi-bot commented 4 months ago

/test ci/centos/k8s-e2e-external-storage/1.29

ceph-csi-bot commented 4 months ago

/test ci/centos/mini-e2e-helm/k8s-1.30

ceph-csi-bot commented 4 months ago

/test ci/centos/mini-e2e-helm/k8s-1.29

ceph-csi-bot commented 4 months ago

/test ci/centos/mini-e2e-helm/k8s-1.28

ceph-csi-bot commented 4 months ago

/test ci/centos/mini-e2e/k8s-1.29

ceph-csi-bot commented 4 months ago

/test ci/centos/mini-e2e/k8s-1.30

ceph-csi-bot commented 4 months ago

/test ci/centos/mini-e2e/k8s-1.28

ceph / ceph-csi

cephfs: close dir #4631

Describe what this PR does

Is there anything that requires special attention

Related issues

Future concerns

✅ Branch has been successfully rebased

🛑 The pull request has been removed from the queue `default`

✅ Branch has been successfully rebased

✅ The pull request has been merged automatically

ceph / ceph-csi

cephfs: close dir #4631

Describe what this PR does

Is there anything that requires special attention

Related issues

Future concerns

✅ Branch has been successfully rebased

🛑 The pull request has been removed from the queue default

✅ Branch has been successfully rebased

✅ The pull request has been merged automatically

🛑 The pull request has been removed from the queue `default`