ceph / ceph-csi

CSI driver for Ceph
Apache License 2.0
1.19k stars 528 forks source link

csi-addons/rbd: make use of volume locks for reclaim space operations #4637

Open Rakshith-R opened 1 month ago

Rakshith-R commented 1 month ago

Describe the bug

Reclaim space operations need to be protected with volume locks similar to other calls to prevent multiple process executing rbd sparsify / fstrim on same volume.

refer: https://github.com/ceph/ceph-csi/blob/devel/internal/csi-addons/rbd/replication.go#L238

Environment details

Steps to reproduce

Steps to reproduce the behavior:

  1. Setup details: '...'
  2. Deployment to trigger the issue '....'
  3. See error

Actual results

Multiple rbd sparsify/ fstrim can be triggered in case the process takes too long and controller times out.

Expected behavior

Only one rbd sparsify/ fstrim process per volume should run at a time.

github-actions[bot] commented 1 week ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 1 day ago

This issue has been automatically closed due to inactivity. Please re-open if this still requires investigation.