1602077 commented 3 weeks ago

Describe what this PR does

Pod level security context are configurable via helm values.yaml for provisioner deployment and nodeplugin daemonset with a default of no securityContext specified.

Fixes: #4663

Checklist:

[x] Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
[x] Reviewed the developer guide on Submitting a Pull Request
[x] Pending release notes updated with breaking and/or notable changes for the next major release.
[x] Documentation has been updated, if necessary.
[x] Unit tests have been added, if necessary.
[x] Integration tests have been added, if necessary.

nixpanic commented 3 weeks ago

Looks good to me, thanks for the PR!

1602077 commented 3 weeks ago

Cheers for the quick review much appreciated!

Have replicated changes for rbd in follow up PR.

nixpanic commented 3 weeks ago

@mergifyio rebase

mergify[bot] commented 3 weeks ago

rebase

✅ Branch has been successfully rebased

nixpanic commented 3 weeks ago

@mergifyio queue

mergify[bot] commented 3 weeks ago

queue

🛑 The pull request has been removed from the queue `default`

The queue conditions cannot be satisfied due to failing checks. You can take a look at `Queue: Embarked in merge queue` check runs for more details. In case of a failure due to a flaky test, you should first retrigger the CI. Then, re-embark the pull request into the merge queue by posting the comment `@mergifyio refresh` on the pull request.

ceph-csi-bot commented 3 weeks ago

/test ci/centos/k8s-e2e-external-storage/1.28

ceph-csi-bot commented 3 weeks ago

/test ci/centos/upgrade-tests-cephfs

ceph-csi-bot commented 3 weeks ago

/test ci/centos/k8s-e2e-external-storage/1.27

ceph-csi-bot commented 3 weeks ago

/test ci/centos/mini-e2e-helm/k8s-1.28

ceph-csi-bot commented 3 weeks ago

/test ci/centos/k8s-e2e-external-storage/1.29

ceph-csi-bot commented 3 weeks ago

/test ci/centos/upgrade-tests-rbd

ceph-csi-bot commented 3 weeks ago

/test ci/centos/mini-e2e-helm/k8s-1.27

ceph-csi-bot commented 3 weeks ago

/test ci/centos/mini-e2e/k8s-1.28

ceph-csi-bot commented 3 weeks ago

/test ci/centos/mini-e2e-helm/k8s-1.29

ceph-csi-bot commented 3 weeks ago

/test ci/centos/k8s-e2e-external-storage/1.30

ceph-csi-bot commented 3 weeks ago

/test ci/centos/mini-e2e/k8s-1.27

ceph-csi-bot commented 3 weeks ago

/test ci/centos/mini-e2e/k8s-1.29

ceph-csi-bot commented 3 weeks ago

/test ci/centos/mini-e2e-helm/k8s-1.30

ceph-csi-bot commented 3 weeks ago

/test ci/centos/mini-e2e/k8s-1.30

ceph-csi-bot commented 3 weeks ago

/test ci/centos/k8s-e2e-external-storage/1.30

ceph-csi-bot commented 3 weeks ago

/test ci/centos/mini-e2e-helm/k8s-1.30

ceph-csi-bot commented 3 weeks ago

/test ci/centos/k8s-e2e-external-storage/1.27

ceph-csi-bot commented 3 weeks ago

/test ci/centos/mini-e2e/k8s-1.30

ceph-csi-bot commented 3 weeks ago

/test ci/centos/mini-e2e-helm/k8s-1.27

ceph-csi-bot commented 3 weeks ago

/test ci/centos/k8s-e2e-external-storage/1.28

ceph-csi-bot commented 3 weeks ago

/test ci/centos/mini-e2e/k8s-1.27

ceph-csi-bot commented 3 weeks ago

/test ci/centos/upgrade-tests-cephfs

ceph-csi-bot commented 3 weeks ago

/test ci/centos/mini-e2e-helm/k8s-1.28

ceph-csi-bot commented 3 weeks ago

/test ci/centos/mini-e2e/k8s-1.28

ceph-csi-bot commented 3 weeks ago

/test ci/centos/upgrade-tests-rbd

ceph-csi-bot commented 3 weeks ago

/test ci/centos/k8s-e2e-external-storage/1.29

ceph-csi-bot commented 3 weeks ago

/test ci/centos/mini-e2e-helm/k8s-1.29

ceph-csi-bot commented 3 weeks ago

/test ci/centos/mini-e2e/k8s-1.29

nixpanic commented 3 weeks ago

oh no, PendingReleaseNotes.md was modified by an other PR, and now there is a conflict :sob:

@1602077 could you address the conflict, and force-push the change to your branch to update this PR?

1602077 commented 3 weeks ago

@nixpanic sure thing - have updated. let me know if you need anything else from me. same thing is going to happen for the rbd PR. once this is merged in I will address the conflicts on that one too

ceph-csi-bot commented 3 weeks ago

/test ci/centos/k8s-e2e-external-storage/1.30

ceph-csi-bot commented 3 weeks ago

/test ci/centos/mini-e2e-helm/k8s-1.30

ceph-csi-bot commented 3 weeks ago

/test ci/centos/mini-e2e/k8s-1.30

ceph-csi-bot commented 3 weeks ago

/test ci/centos/upgrade-tests-cephfs

ceph-csi-bot commented 3 weeks ago

/test ci/centos/k8s-e2e-external-storage/1.29

ceph-csi-bot commented 3 weeks ago

/test ci/centos/upgrade-tests-rbd

ceph-csi-bot commented 3 weeks ago

/test ci/centos/mini-e2e-helm/k8s-1.29

ceph-csi-bot commented 3 weeks ago

/test ci/centos/k8s-e2e-external-storage/1.27

ceph-csi-bot commented 3 weeks ago

/test ci/centos/mini-e2e/k8s-1.29

ceph-csi-bot commented 3 weeks ago

/test ci/centos/mini-e2e-helm/k8s-1.27

ceph-csi-bot commented 3 weeks ago

/test ci/centos/k8s-e2e-external-storage/1.28

ceph-csi-bot commented 3 weeks ago

/test ci/centos/mini-e2e/k8s-1.27

ceph-csi-bot commented 3 weeks ago

/test ci/centos/mini-e2e-helm/k8s-1.28

ceph-csi-bot commented 3 weeks ago

/test ci/centos/mini-e2e/k8s-1.28

ceph / ceph-csi

deploy: configurable podSecurityContexts in ceph-csi-cephfs chart #4664

Describe what this PR does

✅ Branch has been successfully rebased

🛑 The pull request has been removed from the queue `default`

ceph / ceph-csi

deploy: configurable podSecurityContexts in ceph-csi-cephfs chart #4664

Describe what this PR does

✅ Branch has been successfully rebased

🛑 The pull request has been removed from the queue default

🛑 The pull request has been removed from the queue `default`